fix: Enforce unsetting openfile when the viewer is closed #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <[email protected]>
artonge
commented
Jul 15, 2024
Contributor
Author
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
/backport to stable29
artonge
commented
Jul 15, 2024
Contributor
Author
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
/backport to stable29
artonge
commented
Jul 15, 2024
Contributor
Author
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
/backport to stable28
artonge
added
bug
Signed-off-by: Louis Chemineau <[email protected]>
susnux
reviewed
Jul 16, 2024
susnux
approved these changes
Jul 16, 2024
Contributor
Author
|
/backport to stable29 |
This comment was marked as outdated.
This comment was marked as outdated.
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
backportbot
bot
added
backport-request
Contributor
Author
|
/backport 2923900 to stable28 |
2 tasks
backportbot
bot
removed
the
backport-request
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
8 tasks
8 tasks
Closed
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can occure when the view is loaded with the openfile set already. Or when creating a file.