Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: fix cypress visual regression and modal name selector
Signed-off-by: skjnldsv <[email protected]>
  • Loading branch information
skjnldsv committed Sep 4, 2024
commit 38b5057aaf0ffa80c788bf8efabb27b6c11fc485
9,340 changes: 9,340 additions & 0 deletions css/main-Cy1Ul0E2.chunk.css

Large diffs are not rendered by default.

9,340 changes: 9,340 additions & 0 deletions css/main-DCLMh14u.chunk.css

Large diffs are not rendered by default.

9,685 changes: 2 additions & 9,683 deletions css/viewer-main.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion cypress/e2e/a11y.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('A11y tests', function() {
})

it('See the title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image2.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image2.jpg')
})

it('Should have rendered the previous video and the next image', function() {
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/actions/sidebar.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('Open the sidebar from the viewer and open viewer with sidebar already
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/audios/audios.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('Open mp3 and ogg audio in viewer', function() {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'audio.mp3')
cy.get('body > .viewer .modal-header__name').should('contain', 'audio.mp3')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/images/images-custom-list-loadmore.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ describe('Open custom list of images in viewer with pagination', function() {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down
6 changes: 3 additions & 3 deletions cypress/e2e/images/images-custom-list.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ describe('Open custom images list in viewer', function() {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down Expand Up @@ -134,7 +134,7 @@ describe('Open custom images list in viewer', function() {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image3.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image3.jpg')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand All @@ -160,7 +160,7 @@ describe('Open custom images list in viewer', function() {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/images/images.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe('Open images in viewer', function() {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/mixins/audio.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default function(fileName = 'audio.ogg', mimeType = 'audio/ogg') {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', fileName)
cy.get('body > .viewer .modal-header__name').should('contain', fileName)
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/mixins/image.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default function(fileName = 'image1.jpg', mimeType = 'image/jpeg', source
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', fileName)
cy.get('body > .viewer .modal-header__name').should('contain', fileName)
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/mixins/oddname.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export default function(file, type, sidebar = false) {
*/
function menuOk() {
cy.get('body > .viewer .icon-error').should('not.exist')
cy.get('body > .viewer .modal-name').should('contain', placedName)
cy.get('body > .viewer .modal-header__name').should('contain', placedName)
cy.get('body > .viewer .modal-header button.header-close').should(
'be.visible',
)
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/mixins/video.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default function(fileName = 'image1.jpg', mimeType = 'image/jpeg') {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', fileName)
cy.get('body > .viewer .modal-header__name').should('contain', fileName)
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/non-dav-files.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describe('Open non-dav files in viewer', function() {
})

it('See the title and close button on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', basename)
cy.get('body > .viewer .modal-header__name').should('contain', basename)
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})

Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/sharing/download-share-disabled.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe(`Download ${fileName} in viewer`, function() {
})

it('See the title on the viewer header but not the Download nor the menu button', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image1.jpg')
cy.get('body a[download="image1.jpg"]').should('not.exist')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('not.exist')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/sharing/download-share.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe(`Download ${fileName} from viewer in link share`, function() {
})

it('See the title and the close icon on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})

Expand Down
4 changes: 2 additions & 2 deletions cypress/e2e/sharing/files-shares.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describe('See shared folder with link share', function() {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header__name').should('contain', 'image1.jpg')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})

Expand Down Expand Up @@ -141,7 +141,7 @@ describe('See shared folder with link share', function() {
cy.get('body > .viewer .modal-container video').should('have.length', 1)
cy.get('body > .viewer button.prev').should('be.visible')
cy.get('body > .viewer button.next').should('be.visible')
cy.get('body > .viewer .modal-name').should('contain', 'video1.mp4')
cy.get('body > .viewer .modal-header__name').should('contain', 'video1.mp4')
})

it('Does not see a loading animation', function() {
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/videos/videos.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('Open mp4 videos in viewer', function() {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'video1.mp4')
cy.get('body > .viewer .modal-header__name').should('contain', 'video1.mp4')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down
4 changes: 2 additions & 2 deletions cypress/e2e/visual-regression.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('Visual regression tests ', function() {
})

it('See the menu icon and title on the viewer header', function() {
cy.get('body > .viewer .modal-name').should('contain', 'test-card.mp4')
cy.get('body > .viewer .modal-header__name').should('contain', 'test-card.mp4')
cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
})
Expand Down Expand Up @@ -108,7 +108,7 @@ describe('Visual regression tests ', function() {
cy.get('body > .viewer').should('not.exist')
cy.openFile('test-card.png')
cy.get('body > .viewer').should('be.visible')
cy.get('body > .viewer .modal-name').should('contain', 'test-card.png')
cy.get('body > .viewer .modal-header__name').should('contain', 'test-card.png')
cy.get('body > .viewer .modal-container img').should('have.length', 1)
cy.get('body > .viewer .modal-container img').should('have.attr', 'src')
cy.get('body > .viewer button.prev').should('be.visible')
Expand Down
Binary file modified cypress/snapshots/base/visual-regression.cy.ts/image.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified cypress/snapshots/base/visual-regression.cy.ts/image2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified cypress/snapshots/base/visual-regression.cy.ts/non-dav.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified cypress/snapshots/base/visual-regression.cy.ts/video.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
41 changes: 24 additions & 17 deletions js/index.chunk.mjs → js/index-u7Jna2OG.chunk.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -10836,8 +10836,8 @@ const Konva$2 = {
_global: glob,
version: "8.4.3",
isBrowser: detectBrowser(),
isUnminified: /param/.test((function(param) {
}).toString()),
isUnminified: /param/.test(function(param) {
}.toString()),
dblClickWindow: 400,
getAngle(angle) {
return Konva$2.angleDeg ? angle * PI_OVER_180 : angle;
Expand Down Expand Up @@ -14355,7 +14355,7 @@ function checkNoClip(attrs = {}) {
}
return attrs;
}
const NO_POINTERS_MESSAGE = "Pointer position is missing and not registered by the stage. Looks like it is outside of the stage container. You can set it manually from event: stage.setPointersPositions(event);";
const NO_POINTERS_MESSAGE = `Pointer position is missing and not registered by the stage. Looks like it is outside of the stage container. You can set it manually from event: stage.setPointersPositions(event);`;
const stages = [];
let Stage$1 = class Stage extends Container$3 {
constructor(config) {
Expand Down Expand Up @@ -17826,7 +17826,7 @@ function normalizeFontFamily(fontFamily2) {
const hasSpace = family.indexOf(" ") >= 0;
const hasQuotes = family.indexOf('"') >= 0 || family.indexOf("'") >= 0;
if (hasSpace && !hasQuotes) {
family = '"'.concat(family, '"');
family = `"${family}"`;
}
return family;
}).join(", ");
Expand Down Expand Up @@ -18475,7 +18475,7 @@ var ATTR_CHANGE_LIST = [
"anchorFillChange",
"anchorCornerRadiusChange",
"ignoreStrokeChange"
].map((e2) => e2 + ".".concat(EVENTS_NAME)).join(" ");
].map((e2) => e2 + `.${EVENTS_NAME}`).join(" ");
var NODES_RECT = "nodesRect";
var TRANSFORM_CHANGE_STR = [
"widthChange",
Expand Down Expand Up @@ -18626,8 +18626,8 @@ let Transformer$1 = class Transformer extends Group$1 {
};
const additionalEvents = node._attrsAffectingSize.map((prop) => prop + "Change." + this._getEventNamespace()).join(" ");
node.on(additionalEvents, onChange2);
node.on(TRANSFORM_CHANGE_STR.map((e2) => e2 + ".".concat(this._getEventNamespace())).join(" "), onChange2);
node.on("absoluteTransformChange.".concat(this._getEventNamespace()), onChange2);
node.on(TRANSFORM_CHANGE_STR.map((e2) => e2 + `.${this._getEventNamespace()}`).join(" "), onChange2);
node.on(`absoluteTransformChange.${this._getEventNamespace()}`, onChange2);
this._proxyDrag(node);
});
this._resetTransformCache();
Expand All @@ -18639,13 +18639,13 @@ let Transformer$1 = class Transformer extends Group$1 {
}
_proxyDrag(node) {
let lastPos;
node.on("dragstart.".concat(this._getEventNamespace()), (e2) => {
node.on(`dragstart.${this._getEventNamespace()}`, (e2) => {
lastPos = node.getAbsolutePosition();
if (!this.isDragging() && node !== this.findOne(".back")) {
this.startDrag(e2, false);
}
});
node.on("dragmove.".concat(this._getEventNamespace()), (e2) => {
node.on(`dragmove.${this._getEventNamespace()}`, (e2) => {
if (!lastPos) {
return;
}
Expand Down Expand Up @@ -18783,9 +18783,9 @@ let Transformer$1 = class Transformer extends Group$1 {
}
_createElements() {
this._createBack();
ANCHORS_NAMES.forEach((function(name) {
ANCHORS_NAMES.forEach(function(name) {
this._createAnchor(name);
}).bind(this));
}.bind(this));
this._createAnchor("rotater");
}
_createAnchor(name) {
Expand Down Expand Up @@ -26028,8 +26028,15 @@ let useStrictMode$1 = false;
function toggleStrictMode(value) {
useStrictMode$1 = value;
}
const DRAGGABLE_WARNING = "ReactKonva: You have a Konva node with draggable = true and position defined but no onDragMove or onDragEnd events are handled.\nPosition of a node will be changed during drag&drop, so you should update state of the react app as well.\nConsider to add onDragMove or onDragEnd events.\nFor more info see: https://github.com/konvajs/react-konva/issues/256\n";
const Z_INDEX_WARNING = 'ReactKonva: You are using "zIndex" attribute for a Konva node.\nreact-konva may get confused with ordering. Just define correct order of elements in your render function of a component.\nFor more info see: https://github.com/konvajs/react-konva/issues/194\n';
const DRAGGABLE_WARNING = `ReactKonva: You have a Konva node with draggable = true and position defined but no onDragMove or onDragEnd events are handled.
Position of a node will be changed during drag&drop, so you should update state of the react app as well.
Consider to add onDragMove or onDragEnd events.
For more info see: https://github.com/konvajs/react-konva/issues/256
`;
const Z_INDEX_WARNING = `ReactKonva: You are using "zIndex" attribute for a Konva node.
react-konva may get confused with ordering. Just define correct order of elements in your render function of a component.
For more info see: https://github.com/konvajs/react-konva/issues/194
`;
const EMPTY_PROPS = {};
function applyNodeProps(instance, props, oldProps = EMPTY_PROPS) {
if (!zIndexWarningShowed && "zIndex" in props) {
Expand Down Expand Up @@ -26105,7 +26112,7 @@ const UPDATE_SIGNAL = {};
Konva$1.Node.prototype._applyProps = applyNodeProps;
function appendInitialChild(parentInstance, child) {
if (typeof child === "string") {
console.error("Do not use plain text as child of Konva.Node. You are using text: ".concat(child));
console.error(`Do not use plain text as child of Konva.Node. You are using text: ${child}`);
return;
}
parentInstance.add(child);
Expand All @@ -26114,7 +26121,7 @@ function appendInitialChild(parentInstance, child) {
function createInstance(type, props, internalInstanceHandle) {
let NodeClass = Konva$1[type];
if (!NodeClass) {
console.error("Konva has no node with the type ".concat(type, '. Group will be used instead. If you use minimal version of react-konva, just import required nodes into Konva: "import "konva/lib/shapes/').concat(type, '" If you want to render DOM elements as part of canvas tree take a look into this demo: https://konvajs.github.io/docs/react/DOM_Portal.html'));
console.error(`Konva has no node with the type ${type}. Group will be used instead. If you use minimal version of react-konva, just import required nodes into Konva: "import "konva/lib/shapes/${type}" If you want to render DOM elements as part of canvas tree take a look into this demo: https://konvajs.github.io/docs/react/DOM_Portal.html`);
NodeClass = Konva$1.Group;
}
const propsWithoutEvents = {};
Expand All @@ -26132,7 +26139,7 @@ function createInstance(type, props, internalInstanceHandle) {
return instance;
}
function createTextInstance(text, rootContainerInstance, internalInstanceHandle) {
console.error('Text components are not supported for now in ReactKonva. Your text is: "'.concat(text, '"'));
console.error(`Text components are not supported for now in ReactKonva. Your text is: "${text}"`);
}
function finalizeInitialChildren(domElement, type, props) {
return false;
Expand Down Expand Up @@ -26207,7 +26214,7 @@ function removeChildFromContainer(parentInstance, child) {
updatePicture(parentInstance);
}
function commitTextUpdate(textInstance, oldText, newText) {
console.error('Text components are not yet supported in ReactKonva. You text is: "'.concat(newText, '"'));
console.error(`Text components are not yet supported in ReactKonva. You text is: "${newText}"`);
}
function commitMount(instance, type, newProps) {
}
Expand Down
1 change: 1 addition & 0 deletions js/index-u7Jna2OG.chunk.mjs.map

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion js/index.chunk.mjs.map

This file was deleted.

Loading