Skip to content

[stable29] fix: Close viewer if we navigate back in browser history #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Jan 8, 2025
Merged

[stable29] fix: Close viewer if we navigate back in browser history #2680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions cypress/e2e/navigation.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
/**
* SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

describe('Browser navigation', function() {
before(function() {
// Init user
cy.createRandomUser().then(user => {
// Upload test files
cy.uploadFile(user, 'image.png', 'image/png', '/image1.png')

// Visit nextcloud
cy.login(user)
cy.visit('/apps/files')
})
})
after(function() {
cy.logout()
})

it('Navigating back to the files overview', function() {
cy.getFile('image1.png', { timeout: 10000 })
cy.openFile('image1.png')
cy.get('body > .viewer').should('be.visible')
cy.go('back')
cy.get('body > .viewer').should('not.exist')
})
})
8 changes: 4 additions & 4 deletions js/vendor.LICENSE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ version: 0.7.5
license: MIT

@floating-ui/core
version: 1.6.0
version: 0.3.1
license: MIT

@floating-ui/dom
version: 1.6.3
version: 0.1.10
license: MIT

@floating-ui/utils
Expand Down Expand Up @@ -73,7 +73,7 @@ version: 2.2.0
license: GPL-3.0-or-later

@nextcloud/l10n
version: 3.1.0
version: 2.2.0
license: GPL-3.0-or-later

@nextcloud/logger
Expand Down Expand Up @@ -141,7 +141,7 @@ version: 11.3.0
license: MIT

@vueuse/shared
version: 11.0.3
version: 11.3.0
license: MIT

ansi-regex
Expand Down
Loading
Loading