Skip to content

fix: Do not update page title for single file public shares #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Apr 4, 2025
+5 −10
Merged

fix: Do not update page title for single file public shares #2789

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92862fb
fix: Do not update page title for single file public shares
juliusknorr Apr 1, 2025
f3611fa
chore(assets): Recompile assets
nextcloud-command Apr 4, 2025
f3a24ed
chore: delete unused 0BSD license
skjnldsv Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Do not update page title for single file public shares 
The filename is empty and is alerady set on page load

Signed-off-by: Julius Knorr <[email protected]>
  • Loading branch information
@juliusknorr @nextcloud-command
juliusknorr authored and nextcloud-command committed Apr 4, 2025
commit 92862fbbf89227d7f88dce80f27bc83eb1397003
2 changes: 1 addition & 1 deletion src/views/Viewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ export default defineComponent({

// swap title with original one
const title = document.getElementsByTagName('head')[0].getElementsByTagName('title')[0]
if (title && !title.dataset.old) {
if (title && !title.dataset.old && fileName !== '') {
title.dataset.old = document.title
this.updateTitle(fileName)
}
Expand Down