Skip to content

[stable29] fix: Do not update page title for single file public shares #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
backportbot wants to merge 1 commit into from
Closed

[stable29] fix: Do not update page title for single file public shares #2795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Do not update page title for single file public shares 
The filename is empty and is alerady set on page load

Signed-off-by: Julius Knorr <[email protected]>
  • Loading branch information
@juliusknorr @backportbot
juliusknorr authored and backportbot[bot] committed Apr 4, 2025
commit 4e9d80747c924812bc92a411c7acb7458e1fc608
2 changes: 1 addition & 1 deletion src/views/Viewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ export default defineComponent({

// swap title with original one
const title = document.getElementsByTagName('head')[0].getElementsByTagName('title')[0]
if (title && !title.dataset.old) {
if (title && !title.dataset.old && fileName !== '') {
title.dataset.old = document.title
this.updateTitle(fileName)
}
Expand Down
Loading