perf: Set and show current file before running heavier request to list directory #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t directory Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
added
3. to review
skjnldsv
approved these changes
May 16, 2025
provokateurin
approved these changes
May 16, 2025
Member
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
backportbot
bot
removed
the
backport-request
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening an image we used to wait with displaying the image until the full directory listing was fetched. As a user I would expect the image i just clicked on to show up as fast as possible, loading the next/previous images is something that can be delayed and happen asynchronously.
To test just add a sleep(5) in https://github.com/nextcloud/server/blob/dc8e16c520cb8a9dd9903f9524957c075ce88d48/apps/dav/lib/Connector/Sabre/Directory.php#L230