Skip to content

fix: add route query for image editor #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hamza221 merged 2 commits into from
Jun 6, 2025
Merged

fix: add route query for image editor #2822

hamza221 merged 2 commits into from
Jun 6, 2025

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented May 20, 2025 •
edited
Loading

Reproduction steps :

  • Open and Image
  • Start editing image
  • Navigate back

@hamza221 hamza221 requested a review from skjnldsv May 20, 2025 12:39
@hamza221 hamza221 added the 3. to review Waiting for reviews label May 20, 2025
@hamza221
Copy link
Contributor Author

hamza221 commented May 20, 2025

/compile /

@hamza221 hamza221 requested a review from szaimen May 20, 2025 15:49
skjnldsv
skjnldsv reviewed May 21, 2025
View reviewed changes
@hamza221 hamza221 force-pushed the Fix/add-route-query-for-editor branch from fd12a17 to 5184aea Compare May 26, 2025 12:04
@hamza221
Copy link
Contributor Author

hamza221 commented May 26, 2025

rebased to resolve conflicts

@szaimen szaimen requested a review from skjnldsv May 27, 2025 09:51
@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 27, 2025
skjnldsv
skjnldsv reviewed May 27, 2025
View reviewed changes
@hamza221 hamza221 force-pushed the Fix/add-route-query-for-editor branch from 5184aea to a4c99c8 Compare June 3, 2025 09:29
@hamza221
Copy link
Contributor Author

hamza221 commented Jun 3, 2025

/compile

@hamza221 hamza221 force-pushed the Fix/add-route-query-for-editor branch 2 times, most recently from 1df1385 to a854de0 Compare June 6, 2025 09:12
@hamza221 hamza221 force-pushed the Fix/add-route-query-for-editor branch from a854de0 to d531abe Compare June 6, 2025 09:21
@hamza221
Copy link
Contributor Author

hamza221 commented Jun 6, 2025

/compile

@nextcloud-command
chore(assets): Recompile assets
1880875 
Signed-off-by: nextcloud-command <[email protected]>
@hamza221 hamza221 enabled auto-merge June 6, 2025 09:30
@hamza221
Copy link
Contributor Author

hamza221 commented Jun 6, 2025

/backport d531abe to stable31

@hamza221
Copy link
Contributor Author

hamza221 commented Jun 6, 2025

/backport d531abe to stable30

@hamza221 hamza221 merged commit 5678644 into master Jun 6, 2025
30 of 31 checks passed
@hamza221 hamza221 deleted the Fix/add-route-query-for-editor branch June 6, 2025 09:32
This was referenced Jun 6, 2025
Merged
Merged
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jun 6, 2025
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Aug 19, 2025

This broke editing in other apps than FIles.
Because you use the window.OCP.Files.Router

Other apps call the viewer open method directly, which doesn't use any part of the file_action. But since you imported it here, we now also use window.OCP.Files.Router when editing, even if it doesn't exist.

See #2936 @hamza221 :)

@skjnldsv skjnldsv mentioned this pull request Aug 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hamza221 @skjnldsv @nextcloud-command