Skip to content

fix: make sure etag is a string #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Jun 20, 2025
Merged

fix: make sure etag is a string #2880

skjnldsv merged 1 commit into from
Jun 20, 2025

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 19, 2025 •
edited
Loading

@skjnldsv skjnldsv requested review from a team, artonge, hamza221, nfebe and susnux and removed request for a team June 19, 2025 08:39
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 19, 2025

/compile amend

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 19, 2025

/backport to stable30

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jun 19, 2025
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 19, 2025

/backport to stable31

@skjnldsv skjnldsv mentioned this pull request Jun 19, 2025
Closed
8 tasks
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 19, 2025

/compile

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 19, 2025

Weird, the build looks outdated

artonge
artonge approved these changes Jun 20, 2025
View reviewed changes
artonge
artonge reviewed Jun 20, 2025
View reviewed changes
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 20, 2025

/compile amend

@skjnldsv @nextcloud-command
fix: make sure etag is a string
e23030a 
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 20, 2025

Unrelated, there's an issue from server

  1) See shared folder with link share
       Opens the shared image in the viewer:
     TypeError: The following error originated from your application code, not from Cypress.

  > self.crypto.randomUUID is not a function

@skjnldsv skjnldsv merged commit c01c64e into master Jun 20, 2025
32 of 41 checks passed
@skjnldsv skjnldsv deleted the skjnldsv-patch-1 branch June 20, 2025 09:51
@backportbot

This comment was marked as resolved.

Sign in to view
@backportbot

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews and removed backport-request Pending backport by the backport-bot labels Jun 21, 2025
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@hamza221 hamza221 hamza221 approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: (Some) images are not shown when large view is requested

5 participants

@skjnldsv @susnux @artonge @hamza221