Fix "wrong owner type" issue when deleting a file from the viewer #2942
Conversation
salmart-dev
force-pushed
the
fix/wrongOwnerType
branch
from
14f362e to
2e423ab
Compare
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
Nice catch! |
|
/compile rebase |
The ownerId is supposed to always be a string value, but if someone's userId is a Numeric name, then file deletion breaks, because the ownerId is taken in as Number. Signed-off-by: Salvatore Martire <[email protected]>
salmart-dev
force-pushed
the
fix/wrongOwnerType
branch
from
2e423ab to
e573302
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/2942/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e573302e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2942/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2942/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e573302e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2942/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/2942/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e573302e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2942/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Fixes: #2943
This PR fixes an issue where deleting a file while being in the viewer fails because of "wrong owner type".
The issue above happens because the
client.statrequests has a Number for ownerId, when the ownerId is a number (e.g. 123456).