Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Sep 2, 2025

  • solves Ticket#9683130

Prevents issues where fonts are offered that the user has not installed.

Prevents issues where fonts are offered that the user has not installed.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux added this to the Nextcloud 32 milestone Sep 2, 2025
@susnux susnux requested review from CarlSchwan and artonge September 2, 2025 10:14
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Sep 2, 2025
@susnux
Copy link
Contributor Author

susnux commented Sep 2, 2025

/backport to stable31

@susnux
Copy link
Contributor Author

susnux commented Sep 2, 2025

/backport to stable30

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Sep 2, 2025
@susnux
Copy link
Contributor Author

susnux commented Sep 2, 2025

/compile

Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit 080cc01 into master Sep 2, 2025
39 of 41 checks passed
@susnux susnux deleted the feat/provide-fonts branch September 2, 2025 12:24
@backportbot
Copy link

backportbot bot commented Sep 2, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/2956/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fcdfd6a6 ff68d4a5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2956/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member

So are the fonts supposed to be shipped in the release?
When doing a build it looks like this:
image
But due to

css/fonts/
they are not in the release tarballs.

@susnux
Copy link
Contributor Author

susnux commented Oct 27, 2025

So are the fonts supposed to be shipped in the release?

Yes - except the roboto ones

@provokateurin
Copy link
Member

Then it's not working as intended, since the files are not committed to git. The release tarballs don't ship any of the fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants