-
Notifications
You must be signed in to change notification settings - Fork 60
feat: only provide fonts which are available (shipped by us) #2956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Prevents issues where fonts are offered that the user has not installed. Signed-off-by: Ferdinand Thiessen <[email protected]>
|
/backport to stable31 |
|
/backport to stable30 |
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2956/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fcdfd6a6 ff68d4a5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2956/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
So are the fonts supposed to be shipped in the release? Line 3 in 114f65f
|
Yes - except the roboto ones |
|
Then it's not working as intended, since the files are not committed to git. The release tarballs don't ship any of the fonts. |

Prevents issues where fonts are offered that the user has not installed.