Skip to content

Conversation

@skjnldsv
Copy link
Member

Fix #28

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Mar 14, 2019
@skjnldsv skjnldsv added this to the next milestone Mar 14, 2019
@skjnldsv skjnldsv self-assigned this Mar 14, 2019
@skjnldsv skjnldsv requested a review from ariselseng March 14, 2019 11:32
@ariselseng
Copy link
Member

ariselseng commented Mar 14, 2019

@skjnldsv
Code looks good. Though In my opinion we should just drop the getMime() in Viewer.vue.
The mime should come from Nextcloud.

It would be very nice if this app could view anything that had had the following conditions: image/** as mimetype and nc:has-previewtrue</nc:has-preview>. That way apps (like mine: https://github.com/cowai/camerarawpreviews) providing previews for other image file types could just work without any integration.

If you look here in my little patch: https://gist.github.com/cowai/1a314c1f32f789ce20b84448cf94be25
You can see that the module 'mime-types' is quite limiting.

EDIT: image/x-dcraw has like 15 different extensions. So it just won't work using that module I think ;)

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 14, 2019

@cowai Sure, I have a pending branch for that like said in #25 (comment) :)
Let me push it

EDIT: #34

Copy link
Member

@ariselseng ariselseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@skjnldsv skjnldsv force-pushed the enhancemet/preview/use-preview-endpoint branch from f56fd76 to b7e083f Compare March 14, 2019 13:01
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the enhancemet/preview/use-preview-endpoint branch from b7e083f to 3b98dd9 Compare March 14, 2019 13:16
@skjnldsv skjnldsv merged commit 4688d15 into master Mar 14, 2019
@skjnldsv skjnldsv deleted the enhancemet/preview/use-preview-endpoint branch March 14, 2019 13:58
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
@skjnldsv skjnldsv modified the milestones: next, Nextcloud 16 Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use previews

3 participants