-
Notifications
You must be signed in to change notification settings - Fork 60
Fix double encoding for stat problem #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gary Kim <[email protected]>
|
@gary-kim Thanks for looking into this. Actually it seems that with this opening files in subdirectories is still broken like "/folder with spaces/foo.jpg" as there is also an encodePath call in FileList.js. Sadly I cannot find any hint on what #357 was supposed to fix. Maybe @ChristophWurst knows, since you have reviewed it? |
|
See nextcloud/photos#122 |
Are you sure? This works just fine for me. |
|
For the record. I'm fine with basically reverting #357 spaces are more common that ? in filenames. |
Huh, I just tried opening a file with this patch applied that had |
|
The path is already properly encoded in the webdav library https://github.com/perry-mitchell/webdav-client/blob/5134ed5dcdda8c7d33f1f3f914904564a52a5935/source/interface/stat.js#L9 so while https://github.com/nextcloud/photos/pull/122/files was needed to fix the encoding of paths in plain axios calls. I'd vote for just reverting #357 then since I cannot find a scenario that was not working before. |
|
Also having a |
|
Thanks for checking @juliushaertl @gary-kim ! |
|
Closing in favor of #395 |
Closes #392
Closes #388
Fix double encoding issue.