Skip to content

Conversation

@skjnldsv
Copy link
Member

Fix #646

@skjnldsv skjnldsv added bug Something isn't working regression Regression of a previous working feature 3. to review Waiting for reviews labels Oct 26, 2020
@skjnldsv skjnldsv added this to the Nextcloud 21 milestone Oct 26, 2020
@skjnldsv skjnldsv requested a review from jakobroehrl October 26, 2020 11:44
@skjnldsv skjnldsv self-assigned this Oct 26, 2020
@skjnldsv skjnldsv force-pushed the fix/click-outside-component branch from 6f7774e to 52f13c6 Compare October 26, 2020 11:45
@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv skjnldsv force-pushed the fix/click-outside-component branch from 52f13c6 to dd7cb1f Compare October 26, 2020 12:04
@skjnldsv
Copy link
Member Author

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/click-outside-component branch 2 times, most recently from 540501b to 9c6d8a2 Compare October 26, 2020 12:07
Copy link
Contributor

@jakobroehrl jakobroehrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is working!

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/click-outside-component branch 2 times, most recently from 9eb804d to b97cc77 Compare October 26, 2020 13:40
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/click-outside-component branch from b97cc77 to 638ca85 Compare October 26, 2020 14:07
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 26, 2020
@skjnldsv
Copy link
Member Author

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 26, 2020
@skjnldsv skjnldsv merged commit 6a64c77 into master Oct 26, 2020
@skjnldsv skjnldsv deleted the fix/click-outside-component branch October 26, 2020 14:29
@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 26, 2020

Argh, merged too fast, also needed nextcloud-libraries/nextcloud-vue#1518
Anyway, will be automatically fixed in the next vue release

@skjnldsv skjnldsv removed the backport-request Pending backport by the backport-bot label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image viewer modal no longer closes when clicking out of image

3 participants