[Help wanted] Add download button in actions menu #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
reviewed
Nov 22, 2020
skjnldsv
added
2. developing
Signed-off-by: Florent Fayolle <[email protected]>
Signed-off-by: Florent Fayolle <[email protected]>
fflorent
force-pushed
the
add-download-button
branch
from
2983947 to
95a1ed7
Compare
skjnldsv
requested changes
Dec 18, 2020
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Getting close.
Still a few comments :)
Comment on lines
+60
to
+65
| <ActionButton | ||
| icon="icon-download" | ||
| :close-after-click="true" | ||
| @click="onDownload"> | ||
| {{ t('viewer', 'Download') }} | ||
| </ActionButton> |
| * @param {object} fileInfo The fileInfo | ||
| * @returns {string} | ||
| */ | ||
| function genDavPath(fileInfo) { |
Member
There was a problem hiding this comment.
More suitable: getDavPath
Suggested change
| function genDavPath(fileInfo) { | |
| function getDavPath(fileInfo) { |
Member
There was a problem hiding this comment.
Also, please keep the same function declaration format
Suggested change
| function genDavPath(fileInfo) { | |
| const getDavPath = function(fileInfo) { |
This comment has been minimized.
This comment has been minimized.
Member
|
Hey @fflorent, do you have any news? Do you need anything? :) |
|
One click download button would be ideal I believe. On mobile even gallery view is to small to really see the photo well and with many photos a two click action menu might be cumbersome... As illustrated: I don’t know what it would take to implement on mobile, but swipe gestures would be really great. swipe down to download to mobile device, swipe up to save it to your Nextcloud or go to where you have it saved. If I could code I would even add customizable swipe to make the whole planet happy. |
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 13, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702
Merged
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 13, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 13, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
Contributor
|
I addressed the comments in #814 |
Member
|
See #814 |
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 25, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 25, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 27, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 27, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 27, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 30, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 30, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 31, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
added a commit
to beardhatcode/viewer
that referenced
this pull request
Mar 31, 2021
This addition is work of @fflorent , I finished his work from nextcloud#702 Signed-off-by: Robbert Gurdeep Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need
As a user, when I preview a file, I would like to download it easily with few clicks.
Rationales
If a file is easily downloadable from the files action popup:
a user not used to Nextcloud may click on a file in order to download it and wouldn't discover this menu.
Hopefully there is an action menu in the top-right corner and I propose to add a download button there:
Technical considerations
I just add a button… Still it opens few questions to me :) :
OCA.Files.Files.handleDownloadmethod, but it requires a callback I don't need. Also I am not sure of its benefits here compared to a simplelocation.href = '…'for this case. Seems like it cookies are used, it's for knowing when the download starts.Cheers!