Limit scope of the icon white overwrite #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
Member
Author
|
/backport to stable21 |
backportbot-nextcloud
bot
added
the
backport-request
skjnldsv
reviewed
Apr 14, 2021
| // force white icon on single buttons | ||
| .action-item--single.icon-menu-sidebar { | ||
| #viewer .action-item--single.icon-menu-sidebar { |
Member
There was a problem hiding this comment.
To be honest, this is fixed with the new Icons fix of the vue components v4 as we're now using the css colour. 🤔
Do you want to wait for the release?
Member
There was a problem hiding this comment.
Ah, well, that still applies for 21 and under
skjnldsv
approved these changes
Apr 14, 2021
Member
|
/backport to stable20 |
|
The backport to stable20 failed. Please do this backport manually. |
backportbot-nextcloud
bot
removed
the
backport-request
This was referenced Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the icon class will be overwritten everywhere with a white icon as reported in nextcloud/deck#2867 (comment) for deck.