Skip to content

Fixes for naughty filenames #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Apr 21, 2021
Merged

Fixes for naughty filenames #868

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3d9587
tests: Add tests for naughty filenames
beardhatcode Apr 18, 2021
02e1b1a
fix: Properly encode the DAV path
beardhatcode Apr 18, 2021
abecd79
fix: make cypress create user more informative
beardhatcode Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: make cypress create user more informative 
Without this commit cypress may sat it has created a user when that
is not the case. Nextcloud returns a 200 HTTP code with a status set
to "failure"

Signed-off-by: Robbert Gurdeep Singh <[email protected]>
  • Loading branch information
@beardhatcode
beardhatcode committed Apr 20, 2021
commit abecd79fbb49c66d8e7f1a972f453db533d3e015
6 changes: 5 additions & 1 deletion cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ Cypress.Commands.add('nextcloudCreateUser', (user, password) => {
Authorization: `Basic ${btoa('admin:admin')}`,
},
}).then(response => {
cy.log(`Created user ${user}`, response.status)
if(response.body.ocs.meta.status.toLowerCase() == "ok"){
cy.log(`Created user ${user}`, response.status)
} else {
throw new Error(`Unable to create user`)
}
})
})

Expand Down