Skip to content

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Apr 21, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #868

@backportbot-nextcloud backportbot-nextcloud bot added the bug Something isn't working label Apr 21, 2021
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 21.0.2 milestone Apr 21, 2021
@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Apr 21, 2021
@beardhatcode
Copy link
Contributor

beardhatcode commented Apr 21, 2021

https://dashboard.cypress.io/projects/xysa6x/runs/2515/test-results/fdee6ce1-1ae1-495b-be3a-b17c92cab73d

Some tests failed:

  • The webp one, because that file was added later and is scheduled for NC22
  • The video test due to some "you must be sub-admin" error

I issued a re-run of the GH actions but that just made the tests green without doing anything...

@beardhatcode beardhatcode force-pushed the backport/868/stable21 branch from c04d83f to accf6d2 Compare April 21, 2021 09:44
@beardhatcode
Copy link
Contributor

Removed the webp test and now everything runs fine :)

@beardhatcode beardhatcode requested a review from skjnldsv April 21, 2021 10:16
Signed-off-by: Robbert Gurdeep Singh <[email protected]>

tests: remove webp test from oddnames test

Signed-off-by: Robbert Gurdeep Singh <[email protected]>
Signed-off-by: Robbert Gurdeep Singh <[email protected]>
Without this commit cypress may sat it has created a user when that
is not the case. Nextcloud returns a 200 HTTP code with a status set
to "failure"

Signed-off-by: Robbert Gurdeep Singh <[email protected]>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@beardhatcode beardhatcode force-pushed the backport/868/stable21 branch from accf6d2 to 22140d4 Compare April 21, 2021 10:17
@skjnldsv skjnldsv merged commit 1cf56af into stable21 Apr 21, 2021
@skjnldsv skjnldsv deleted the backport/868/stable21 branch April 21, 2021 11:41
@beardhatcode
Copy link
Contributor

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Apr 22, 2021
@backportbot-nextcloud
Copy link
Author

The backport to stable20 failed. Please do this backport manually.

@beardhatcode beardhatcode restored the backport/868/stable21 branch April 22, 2021 17:00
@beardhatcode beardhatcode deleted the backport/868/stable21 branch April 22, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants