[stable20] Fixes for naughty filenames #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beardhatcode
force-pushed
the
backport/868/stable20
branch
from
58ca9c2 to
e2f0ffd
Compare
Contributor
Author
|
cypress fails atm |
Contributor
Author
|
@skjnldsv, when I run the test the file is downloaded instead of previewed. And I can't see why. Note: converted to draft to prevent merging, The tests did not pass, but for some reason GH made them green... |
beardhatcode
force-pushed
the
backport/868/stable20
branch
from
ea791da to
cac5308
Compare
Contributor
Author
|
@skjnldsv I can't get it working, for some reason the file is downloaded instead of shown in my local cypress. |
beardhatcode
force-pushed
the
backport/868/stable20
branch
4 times, most recently
from
86fcd10 to
4a705cd
Compare
Contributor
Author
|
I altered the test a bit such that it fails faster. |
Contributor
Author
|
Progress 😄 : it works if the foldername is not naughty |
beardhatcode
force-pushed
the
backport/868/stable20
branch
2 times, most recently
from
e3bfae4 to
ae3f454
Compare
Signed-off-by: Robbert Gurdeep Singh <[email protected]> tests: remove webp test from oddnames test Signed-off-by: Robbert Gurdeep Singh <[email protected]> tests: Use old menu icon name Signed-off-by: Robbert Gurdeep Singh <[email protected]>
This change is based on 85f6806 Signed-off-by: Robbert Gurdeep Singh <[email protected]> Use encodeFilePath as it is availible Signed-off-by: Robbert Gurdeep Singh <[email protected]>
webdav 3.3.0 did not handle URL's with percent signs in them well. Signed-off-by: Robbert Gurdeep Singh <[email protected]>
Without this commit cypress may sat it has created a user when that is not the case. Nextcloud returns a 200 HTTP code with a status set to "failure" Signed-off-by: Robbert Gurdeep Singh <[email protected]> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com> Signed-off-by: Robbert Gurdeep Singh <[email protected]>
Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
force-pushed
the
backport/868/stable20
branch
from
ae3f454 to
d417304
Compare
Contributor
Author
|
@skjnldsv I got it working (locally at least atm, we'll see what GH actions says), could you review this? Differences with #868 :
|
skjnldsv
approved these changes
May 3, 2021
Member
|
You are amazing! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #868