clean: use eslint on oddname + use encodeFilePath #880
Conversation
beardhatcode
force-pushed
the
feat/oddname-clean
branch
from
a49f17f to
24607df
Compare
|
Please rebase :) |
beardhatcode
force-pushed
the
feat/oddname-clean
branch
from
24607df to
071c3af
Compare
instead of split map join - use generateUrl to automatically encode the basename. - Properly test if the error page is not shown Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
force-pushed
the
feat/oddname-clean
branch
2 times, most recently
from
e7e6251 to
aa238c1
Compare
|
I'll need tot test this first since the test has been split Update: https://dashboard.cypress.io/projects/xysa6x/runs/2568/specs (the quick fail still works 😃 ) |
Signed-off-by: Robbert Gurdeep Singh <[email protected]>
beardhatcode
force-pushed
the
feat/oddname-clean
branch
from
9b659d3 to
711ce4b
Compare
beardhatcode
added
3. to review
I think this link is another run, looking at the github action checks, all the tests really passed 🤔 Only one is weird I guess we should make sure to only tests EDIT: this is the last test: https://dashboard.cypress.io/projects/xysa6x/runs/2569/overview |
| let failsLeft = 5 | ||
| Cypress.on('fail', (error, runnable) => { | ||
| failsLeft-- | ||
| throw error // throw error to have test still fail | ||
| }) |
There was a problem hiding this comment.
So, I don't know about this one.
It seems like an odd thing to do, does cypress not support quick-fail on its own?
There was a problem hiding this comment.
It supports quick-fail in their "pro plan" (see cypress-io/cypress#518 (comment)).
There was a problem hiding this comment.
Maybe using https://github.com/javierbrea/cypress-fail-fast is an option, but that would add a dependency that is only used for one thing (and is implemented in 5 + 3 lines of code)
There was a problem hiding this comment.
Maybe using javierbrea/cypress-fail-fast is an option, but that would add a dependency that is only used for one thing (and is implemented in 5 + 3 lines of code)
Let get this in then
|
The cypress link above was to demonstrate that the quickfail works. Before, if there was an error with oddname, the test would take hours (more than 6 hours even, maybe less now that it is split up) This run for example, from when I was porting the naughtlynames patch to stable20: https://github.com/nextcloud/viewer/runs/2474367200?check_suite_focus=true , it took more than 360 minutes to finish, although it was clear that the test had failed after a few minutes. |
Definitely a bug, cypress is usually super fast 🤔 |
Since I've backported #868 I learned more about the codebase, and now I know how to do certain things nicer.
map(encodeURIComponent).join(/)with the already existingencodeFilePathcy.get('body > .viewer .icon-error').should('not.exist')