Skip to content

Add support for video captions #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
douzebis wants to merge 14 commits into from
Closed

Add support for video captions #910

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9cb6408
Add support for video captions
douzebis May 23, 2021
088b678
Fix typo in condition
douzebis May 23, 2021
f2216ad
Use v-for instead of v-html to create tracks
douzebis May 23, 2021
e1eacde
Simplify the code (no need for extra async function)
douzebis May 23, 2021
f681942
Get rid of v-html (and associated warning)
douzebis May 23, 2021
ce00b04
Add js/viewer-main.js* (necessary??)
douzebis May 23, 2021
1362f92
Clean up (cosmetic)
douzebis May 23, 2021
15d412e
Fix typo (lang -> srclang)
douzebis May 23, 2021
be25019
Improve code readability -- use: for (item of items)
douzebis May 23, 2021
9f05ce1
fixup! Improve code readability -- use: for (item of items)
npmbuildbot-nextcloud[bot] May 24, 2021
d4c9014
Fix issue with tracks not always being reactive
douzebis May 24, 2021
01fc82e
Move fetchData() from template to methods
douzebis May 25, 2021
a9cfee1
Try and fix the mess I did with github 'fetch upstream'
douzebis May 27, 2021
31cb81a
Try and fix the mess I did with github 'fetch upstream'
douzebis May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Get rid of v-html (and associated warning) 
Instead fetchTracks() can be called from options().

Signed-off-by: Frederic Ruget <[email protected]>
  • Loading branch information
@douzebis @beardhatcode
douzebis authored and beardhatcode committed May 25, 2021
commit f6819425477d6e21cdd3fbd3452adea94f55ee86
3 changes: 2 additions & 1 deletion src/components/Videos.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<!-- Plyr currently replaces the parent. Wrapping to prevent this
https://github.com/redxtech/vue-plyr/issues/259 -->
<div v-if="davPath">
<div v-html="fetchTracks()" />
<!-- <div v-html="fetchTracks()" /> -->
<VuePlyr
ref="plyr"
:options="options"
Expand Down Expand Up @@ -93,6 +93,7 @@ export default {
return this.$refs.plyr.player
},
options() {
this.fetchTracks()
return {
autoplay: this.active === true,
captions: { active: false, language: 'auto', update: true },
Expand Down