Skip to content

Add support for video captions #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skjnldsv wants to merge 19 commits into from
Closed

Add support for video captions #915

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a2fe910
Add support for video captions
douzebis May 23, 2021
d6ef4d4
Fix typo in condition
douzebis May 23, 2021
7f1955b
Use v-for instead of v-html to create tracks
douzebis May 23, 2021
5aa82d1
Simplify the code (no need for extra async function)
douzebis May 23, 2021
65bf4b5
Get rid of v-html (and associated warning)
douzebis May 23, 2021
86a02b2
Clean up (cosmetic)
douzebis May 23, 2021
c56c9d6
Fix typo (lang -> srclang)
douzebis May 23, 2021
9c30beb
Improve code readability -- use: for (item of items)
douzebis May 23, 2021
5798ae1
Fix issue with tracks not always being reactive
douzebis May 24, 2021
c89e6b3
Move fetchData() from template to methods
douzebis May 25, 2021
ae9fc02
Refactor the caption-fetching code for easier maintenance
douzebis May 30, 2021
b0ccf50
Symplify the code using async/await and array maps
douzebis Jun 1, 2021
bb35246
Use dirname from package @nextcloud/paths
douzebis Jun 1, 2021
f392c41
Put services in the constructor, do callings in the methods
douzebis Jun 1, 2021
160c13e
Prefilter candidate tracks by locale for performance
douzebis Jun 1, 2021
8ab02f5
Swap HTML5 'label' and 'srclang' (order was incorrect)
douzebis Jun 1, 2021
e1ddead
Make VideoController an OCS controller so it's a real API
douzebis Jun 1, 2021
891d11e
Remove VideoController API version (it is not needed)
douzebis Jun 2, 2021
305c63b
Polish stuff a bit
CarlSchwan Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move fetchData() from template to methods 
(Templates are not made to call methods.)

Signed-off-by: Frederic Ruget <[email protected]>
  • Loading branch information
@douzebis @CarlSchwan
douzebis authored and CarlSchwan committed Sep 1, 2022
commit c89e6b349aeebcd7b4c9ec43848f9f65e49e7a8d
10 changes: 5 additions & 5 deletions src/components/Videos.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@
@canplay="doneLoading"
@loadedmetadata="onLoadedMetadata">

{{ fetchTracks() }}

<track v-for="track in tracks"
:key="track"
:src="track.src"
Expand Down Expand Up @@ -81,11 +79,11 @@ Vue.use(VuePlyr)
export default {
name: 'Videos',

data: () => ({
data() {
// This is required so that tracks is declared and reactive
// Otherwise updates may fail to make it to plyr
tracks: [],
}),
return { tracks: [], }
},

computed: {
livePhoto() {
Expand Down Expand Up @@ -165,6 +163,8 @@ export default {
},

onLoadedMetadata() {

this.fetchTracks()
this.updateVideoSize()
// Force any further loading once we have the metadata
if (!this.active) {
Expand Down