Skip to content

Conversation

@gary-kim
Copy link
Member

@gary-kim gary-kim commented Jun 2, 2021

Fixes #906

It seems that for some reason, the comma separated css selector as used here is not working properly. This fixes fullscreen for Firefox users.

@gary-kim gary-kim added bug Something isn't working 3. to review Waiting for reviews labels Jun 2, 2021
@gary-kim gary-kim added this to the Nextcloud 22 milestone Jun 2, 2021
@gary-kim gary-kim requested a review from skjnldsv June 2, 2021 23:47
@gary-kim
Copy link
Member Author

gary-kim commented Jun 2, 2021

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jun 2, 2021
@gary-kim
Copy link
Member Author

gary-kim commented Jun 2, 2021

/backport to stable20

@gary-kim
Copy link
Member Author

gary-kim commented Jun 2, 2021

/backport to stable19

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow 🙄

@skjnldsv skjnldsv merged commit 4690821 into master Jun 3, 2021
@skjnldsv skjnldsv deleted the fix/819/firefox-fullscreen branch June 3, 2021 06:42
@backportbot-nextcloud
Copy link

The backport to stable19 failed. Please do this backport manually.

@skjnldsv skjnldsv removed the backport-request Pending backport by the backport-bot label Jun 3, 2021
@skjnldsv
Copy link
Member

skjnldsv commented Jun 3, 2021

No stable19, I think it was not using plyr back then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Play Full Screen still fails on 21.0.2 (failed on 21.0.1 too)

3 participants