Disable header timeout on mobile #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

szaimen merged 1 commit into master from enh/noid/disable-header-timeout

Jul 19, 2021

Contributor

szaimen commented Jul 8, 2021 •

edited

Loading

Fix #134

Signed-off-by: szaimen [email protected]

szaimen added the 2. developing label

github-actions bot force-pushed the enh/noid/disable-header-timeout branch from f0a4d77 to 4419286 Compare

July 8, 2021 23:05

szaimen added this to the Nextcloud 23 milestone

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

szaimen added 3. to review design enhancement and removed 2. developing labels

szaimen marked this pull request as ready for review

July 19, 2021 12:10

szaimen closed this

szaimen reopened this

szaimen requested review from Pytal, artonge, jancborchardt, julien-nc, nimishavijay and skjnldsv

July 19, 2021 12:15

artonge reviewed

View reviewed changes

src/views/Viewer.vue Outdated Show resolved Hide resolved

Member

jancborchardt commented Jul 19, 2021

@szaimen thank you for the explanation! :) Hiding the controls is not only valuable for when you are in a slideshow though, but also generally when viewing photos and you want to just focus on the pictures. Yes, mobile is an issue, but there a different solution is required.

Ideally it would be like this:

Desktop: Stays like it is, with the timeout of title and controls (also often for photos, the title is nonsense). This makes it so it’s clutter-free when navigating either via arrow keys or using the slideshow.
Mobile/touch: Like default on Android, where the header is shown or not when tapping on the picture instead of based on a timeout. There, it would also be very nice to have the swipe like on mobile of course, where the next picture comes swiping in etc – and we don’t need the left/right arrows actually.

So basically, I’d rather have us improve the mobile/touch experience rather than reducing down the desktop experience. Hope that makes sense? cc @nimisha-vijay

Contributor Author

szaimen commented Jul 19, 2021

@jancborchardt Thanks for the feedback! So I'll come up with a different solution that disables the timeout only for mobile :)

szaimen force-pushed the enh/noid/disable-header-timeout branch 2 times, most recently from 03b9694 to 996715a Compare

July 19, 2021 14:54

szaimen changed the title ~~Disable header timeout~~ Disable header timeout on mobile

szaimen commented

View reviewed changes

src/views/Viewer.vue Outdated Show resolved Hide resolved

juliusknorr reviewed

View reviewed changes

src/views/Viewer.vue Outdated Show resolved Hide resolved

szaimen force-pushed the enh/noid/disable-header-timeout branch from 996715a to 30f8efe Compare

July 19, 2021 15:24

github-actions bot force-pushed the enh/noid/disable-header-timeout branch from 30f8efe to 6b18b3b Compare

July 19, 2021 15:28

szaimen force-pushed the enh/noid/disable-header-timeout branch from 6b18b3b to b8a1a09 Compare

July 19, 2021 15:33

skjnldsv reviewed

View reviewed changes

src/views/Viewer.vue Outdated Show resolved Hide resolved

szaimen added 2. developing and removed 3. to review labels

szaimen force-pushed the enh/noid/disable-header-timeout branch 2 times, most recently from 798b8dc to fac14c5 Compare

July 19, 2021 15:52

github-actions bot force-pushed the enh/noid/disable-header-timeout branch from fac14c5 to 335a794 Compare

July 19, 2021 15:59

julien-nc previously requested changes

View reviewed changes

src/views/Viewer.vue Outdated Show resolved Hide resolved

szaimen force-pushed the enh/noid/disable-header-timeout branch from 335a794 to 0e7ec4f Compare

July 19, 2021 16:06

This comment has been minimized.

Sign in to view


          Disable header timeout

5b865e2

Signed-off-by: szaimen <[email protected]>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

github-actions bot force-pushed the enh/noid/disable-header-timeout branch from 0e7ec4f to 5b865e2 Compare

July 19, 2021 16:08

szaimen closed this

szaimen reopened this

Contributor Author

szaimen commented Jul 19, 2021

Everything done. Please re-review :)

szaimen added 3. to review and removed 2. developing labels

Pytal approved these changes

View reviewed changes

szaimen dismissed julien-nc’s stale review

July 19, 2021 16:30

The requested changes were implemented.

julien-nc self-requested a review

July 19, 2021 21:13

julien-nc approved these changes

View reviewed changes

szaimen merged commit 84cc9da into master

szaimen deleted the enh/noid/disable-header-timeout branch

July 19, 2021 21:22

Contributor Author

szaimen commented Jul 19, 2021

/backport to stable22

backportbot-nextcloud bot added the backport-request label

Contributor Author

szaimen commented Jul 19, 2021

/backport to stable21

Contributor Author

szaimen commented Jul 19, 2021

/backport to stable20

This was referenced Jul 19, 2021

[stable21] Disable header timeout on mobile #976

Merged

[stable22] Disable header timeout on mobile #977

Merged

backportbot-nextcloud bot removed the backport-request label

backportbot-nextcloud bot mentioned this pull request

[stable20] Disable header timeout on mobile #978

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

juliusknorr juliusknorr left review comments

artonge artonge left review comments

skjnldsv skjnldsv left review comments

julien-nc julien-nc approved these changes

Pytal Pytal approved these changes

jancborchardt Awaiting requested review from jancborchardt

nimishavijay Awaiting requested review from nimishavijay

Labels

3. to review design enhancement