Skip to content

fix version viewer regression #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hweihwang merged 2 commits into from
Jan 13, 2026
Merged

fix version viewer regression #884

hweihwang merged 2 commits into from
Jan 13, 2026
+509 −51

Conversation

@hweihwang
Copy link
Contributor

@hweihwang hweihwang commented Dec 17, 2025 •
edited
Loading

@hweihwang hweihwang requested review from benjaminfrueh and removed request for grnd-alt December 17, 2025 08:36
@juliusknorr
Copy link
Member

juliusknorr commented Dec 17, 2025

Can we have a test cover this as well? Are we missing any other scenarios in test coverage?

juliusknorr
juliusknorr reviewed Dec 17, 2025
View reviewed changes
@juliusknorr juliusknorr added the bug Something isn't working label Dec 17, 2025
@hweihwang hweihwang force-pushed the fix/version-viewer-regression branch from df16c53 to b159b27 Compare December 19, 2025 09:20
silverkszlo
silverkszlo reviewed Jan 7, 2026
View reviewed changes
silverkszlo
silverkszlo reviewed Jan 8, 2026
View reviewed changes
silverkszlo
silverkszlo reviewed Jan 8, 2026
View reviewed changes
silverkszlo
silverkszlo reviewed Jan 8, 2026
View reviewed changes
silverkszlo
silverkszlo reviewed Jan 8, 2026
View reviewed changes
@hweihwang hweihwang force-pushed the fix/version-viewer-regression branch 2 times, most recently from 0b7104a to f27227a Compare January 12, 2026 12:31
@hweihwang hweihwang force-pushed the fix/version-viewer-regression branch from f27227a to f7fcdc1 Compare January 13, 2026 11:27
@hweihwang hweihwang merged commit f9d162c into main Jan 13, 2026
31 checks passed
@hweihwang hweihwang deleted the fix/version-viewer-regression branch January 13, 2026 11:46
@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jan 14, 2026

Can we have this as a backport for 1.5.2.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr left review comments

@silverkszlo silverkszlo silverkszlo left review comments

@benjaminfrueh benjaminfrueh benjaminfrueh approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hweihwang @juliusknorr @tobiasKaminsky @silverkszlo @benjaminfrueh