Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Sep 9, 2019

No description provided.

@juliusknorr
Copy link
Member

Frontend added:

image

The bundle size of 200kb is an issue, caused by importing the multiselect from nextcloud-vue compared to 55kb when just pulling in vue-multiselect and the styles.

@juliusknorr
Copy link
Member

  • The "Keep original, preserve existing PDFs is a bit wide? Could just hide the border around it and instead use the .icon-caret right of it.

blizzz and others added 2 commits December 16, 2019 14:57
juliusknorr and others added 5 commits December 17, 2019 15:19
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz marked this pull request as ready for review December 17, 2019 14:27
@blizzz blizzz requested a review from juliusknorr December 17, 2019 14:31
@blizzz
Copy link
Member Author

blizzz commented Dec 17, 2019

merging as discussed

@blizzz blizzz merged commit ebd60ec into master Dec 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/wfe-18 branch December 17, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants