Skip to content

update PSMN configuration to keep up with cluster changes#788

Merged
jfy133 merged 11 commits intonf-core:masterfrom
l-modolo:master
Dec 19, 2024
Merged

update PSMN configuration to keep up with cluster changes#788
jfy133 merged 11 commits intonf-core:masterfrom
l-modolo:master

Conversation

@l-modolo
Copy link
Contributor

@l-modolo l-modolo commented Nov 5, 2024


name: psmn
about: update PSMN configuration to keep up with cluster changes

@l-modolo
Copy link
Contributor Author

Hello,

I applied all the recommended modifications, please tell me if there is anything else I should modify.

Best,

@jfy133 jfy133 self-requested a review November 13, 2024 12:35
@jfy133
Copy link
Member

jfy133 commented Nov 13, 2024

You're good to merge @l-modolo !

@l-modolo
Copy link
Contributor Author

Hi,

Maybe I missed something, but how do I merge this pull request, now that it has been approved ?
I thought that it was already merged, but apparently it's not the case.

Best,
Laurent

@l-modolo
Copy link
Contributor Author

Hi @jfy133,

sorry to bother you again, but how do I merge this pull request to the master branch ?

Best,
Laurent

@jfy133
Copy link
Member

jfy133 commented Dec 19, 2024

Do you not have a merge pull request button?

image

Are you already in the github nfcore organisation?? https://nf-co.re/join

Otherwise I'll merge on your behalf

@jfy133 jfy133 merged commit 077c831 into nf-core:master Dec 19, 2024
138 checks passed
@l-modolo
Copy link
Contributor Author

No I don't think I had one, I could only update my depos to match the last commit from this one.

Anyway, thank you for the merge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants