Skip to content

Add default syslog server #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add default syslog server #1317

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7ba2ab7
add default syslog server
aphralG Oct 3, 2025
124aae9
Merge branch 'main' into nap-default-server
aphralG Oct 7, 2025
544169c
Merge branch 'main' into nap-default-server
aphralG Oct 13, 2025
7a78d3b
Merge branch 'main' into nap-default-server
aphralG Oct 14, 2025
b6501d8
PR feedback
aphralG Oct 14, 2025
2300301
PR feedback
aphralG Oct 23, 2025
56242b0
PR feedback
aphralG Oct 28, 2025
64cd514
PR feedback
aphralG Oct 28, 2025
1940920
Fix log
dhurley Nov 3, 2025
1c9c005
Merge branch 'main' into nap-default-server
aphralG Nov 3, 2025
af10ba7
merge main
aphralG Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR feedback
  • Loading branch information
@aphralG
aphralG committed Oct 23, 2025
commit 2300301c220a50f1bea03e224c8eec6ccb7a9695
2 changes: 0 additions & 2 deletions internal/collector/otel_collector_plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,8 +724,6 @@ func (oc *Collector) findAvailableSyslogServer(ctx context.Context, napSyslogSer
slog.DebugContext(ctx, "Failed to close syslog server", "address", napSyslogServer, "error", closeError)
}

slog.InfoContext(ctx, "Found valid NAP syslog server", "address", napSyslogServer)

oc.previousNAPSysLogServer = napSyslogServer

return napSyslogServer
Expand Down
15 changes: 9 additions & 6 deletions internal/datasource/config/nginx_config_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,12 +250,6 @@ func (ncp *NginxConfigParser) createNginxConfigContext(
nginxConfigContext.PlusAPIs = append(nginxConfigContext.PlusAPIs, plusAPIs...)
}

if napEnabled && nginxConfigContext.NAPSysLogServer == "" {
slog.WarnContext(ctx, fmt.Sprintf("Could not find available local NGINX App Protect syslog"+
" server configured on port %s. Security violations will not be collected.",
ncp.agentConfig.SyslogServer.Port))
}

fileMeta, err := files.FileMeta(conf.File)
if err != nil {
slog.WarnContext(ctx, "Unable to get file metadata", "file_name", conf.File, "error", err)
Expand All @@ -264,6 +258,15 @@ func (ncp *NginxConfigParser) createNginxConfigContext(
}
}

if napEnabled && nginxConfigContext.NAPSysLogServer == "" {
slog.WarnContext(ctx, fmt.Sprintf("Could not find available local NGINX App Protect syslog"+
" server configured on port %s. Security violations will not be collected.",
ncp.agentConfig.SyslogServer.Port))
} else {
slog.InfoContext(ctx, fmt.Sprintf("Found available local NGINX App Protect syslog"+
"server configured on port %s", ncp.agentConfig.SyslogServer.Port))
}

nginxConfigContext.StubStatus = ncp.FindStubStatusAPI(ctx, nginxConfigContext)
nginxConfigContext.PlusAPI = ncp.FindPlusAPI(ctx, nginxConfigContext)

Expand Down
Loading