Skip to content

Conversation

@xeioex
Copy link
Contributor

@xeioex xeioex commented Oct 29, 2024

No description provided.

@xeioex xeioex marked this pull request as draft October 29, 2024 06:55
VadimZhestikov
VadimZhestikov previously approved these changes Oct 29, 2024
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex marked this pull request as ready for review October 30, 2024 01:04
@xeioex xeioex requested a review from VadimZhestikov October 30, 2024 01:04
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only style issues are found, balance of lock/unlock, and GC related stuff looks good.

Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex merged commit 352c2e5 into nginx:master Oct 30, 2024
1 check passed
@xeioex xeioex deleted the qjs_shared_dict branch October 30, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants