Njs fetch cleanup #888
Closed
Njs fetch cleanup #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongzhidao
force-pushed
the
njs-fetch-cleanup
branch
from
1454677 to
25e74d0
Compare
xeioex
requested changes
Apr 11, 2025
| static njs_int_t ngx_js_fetch_init(njs_vm_t *vm); | ||
|
|
||
|
|
||
| njs_inline void |
Contributor
There was a problem hiding this comment.
Let's make it an ordinary static function and move somewhere down.
It is up to compiler to inline it.
|
|
||
|
|
||
| njs_inline void | ||
| ngx_js_http_close_peer(ngx_js_http_t *http) |
Contributor
There was a problem hiding this comment.
Let's make it an ordinary static function and move somewhere down.
It is up to compiler to inline it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepared for related ngx_js_http_* patch.