Add URL encoding to auth_redir cookie value #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing a URI directly in the auth_redir cookie without encoding has led to issues where browsers misinterpret special characters, like semicolons, as part of the cookie delimiter. This behavior results in the truncation of the URI at the special character, causing incomplete or incorrect redirection URLs after user authentication.
Contributor
Author
|
This request is intended to fix issue #85. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing a URI directly in the
auth_redircookie without encoding has led to issues where browsers misinterpret special characters, like semicolons, as part of the cookie delimiter. This behavior results in the truncation of the URI at the special character, causing incomplete or incorrect redirection URLs after user authentication.