ref(example): close Sidenav when logoutConfirmation is dispatched#2189
Merged
brandonroberts merged 19 commits intoNov 5, 2019
Merged
Conversation
Collaborator
|
Preview docs changes for 90704a7 at https://previews.ngrx.io/pr2189-90704a7/ |
Member
|
Hi @jordanpowell88 |
Member
|
Thanks for the PR @jordanpowell88. This change was meant to be simpler, with the |
Contributor
Author
|
Sorry guys I can make those changes here shortly |
… and dispatch closeSidenav Closes ngrx#2186
…/jordanpowell88/platform into remove-dispatching-double-action
jordanpowell88
changed the title
added 4 commits
November 5, 2019 14:36
brandonroberts
approved these changes
Nov 5, 2019
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 8, 2019
refactor(effects): refactor types in effects, expose metadata key for createEffect refactor(example): close sidenav when logoutConfirmation is dispatched (ngrx#2189) Closes ngrx#2186 docs: remove github link from navigation (ngrx#2188) Closes ngrx#2185 feat(schematics): add message prompts for individual schematics (ngrx#2143) test(store): fix flaky integration test (ngrx#2209)
jordanpowell88
added a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #2186
What is the new behavior?
Adds Layout Effect to listen for logoutConfirmation and dispatches closeSidenav
Does this PR introduce a breaking change?
Other information