Skip to content

fix(effects): export CreateEffectMetadata#2245

Merged
timdeschryver merged 1 commit into
ngrx:masterfrom
alex-okrushko:metadata-export
Nov 12, 2019
Merged

fix(effects): export CreateEffectMetadata#2245
timdeschryver merged 1 commit into
ngrx:masterfrom
alex-okrushko:metadata-export

Conversation

@alex-okrushko

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Re-exports CreateEffectMetadata that was added to the createEffect(...) signature recently.

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes # #2243

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot

ngrxbot commented Nov 12, 2019

Copy link
Copy Markdown
Collaborator

Preview docs changes for 307cb5f at https://previews.ngrx.io/pr2245-307cb5f/

@timdeschryver timdeschryver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I didn't know it should be exported to be able to build a lib... it isn't giving any problems while building the application itself.

@timdeschryver timdeschryver merged commit bfe4c81 into ngrx:master Nov 12, 2019
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants