Skip to content

Conversation

@organom
Copy link
Member

@organom organom commented Oct 4, 2018

Added install script for mac and make build and make clean as helpers for development.

@organom organom requested a review from ilyash-b October 4, 2018 09:58
install-mac.sh Outdated
@@ -0,0 +1,14 @@
#!/bin/bash

brew bundle --file=- <<-EOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use Brewfile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont remember why i was doing this via brewfile anymore. left if as normal brew install commands. Anything you can remember that would make us needed the brewfile?

Copy link
Contributor

@ilyash-b ilyash-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs organizing as per comments.

… outside of the makefile in independent scripts, since they are one time run only.
@ilyash-b ilyash-b merged commit 5a3f7fe into dev Jan 5, 2019
@organom organom deleted the BuildHelpers branch January 11, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants