Skip to content

Conversation

@rajsite
Copy link
Member

@rajsite rajsite commented Dec 10, 2025

Pull Request

🀨 Rationale

Moves UnitFormat to a standalone npm library and modifies it to be usable from both browser and node applications.

πŸ‘©β€πŸ’» Implementation

  • Added @ni/unit-format using node esm compliant import paths
  • Breaking: Renamed types to align with folder layout and with nimble components naming conventions, see discussion.
    • Did regex searches for \w+unitformat and \w+unitscale which are the primary uses of the public api for missed renames

πŸ§ͺ Testing

  • Added jasmine node and karma browser tests
  • Draft SystemLinkShared PR, looks like usage was well-encapsulated so trivial change

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed. Added README and Contributing for library.

@rajsite rajsite mentioned this pull request Dec 31, 2025
10 tasks
@rajsite rajsite marked this pull request as ready for review December 31, 2025 07:50
@rajsite rajsite requested a review from jattasNI December 31, 2025 07:51
@rajsite
Copy link
Member Author

rajsite commented Jan 2, 2026

@jattasNI ready for review, won't bypass since it's a breaking change and to review the public api export names (i.e. biggest thing to focus on is the nimble-components and nimble-angular imports of @ni/unit-format)

Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an absolute unit of a PR!

@rajsite rajsite requested a review from msmithNI as a code owner January 13, 2026 05:42
@rajsite rajsite removed the request for review from msmithNI January 13, 2026 05:45
@rajsite rajsite requested a review from fredvisser as a code owner January 13, 2026 06:02
@rajsite rajsite merged commit e26c67a into main Jan 15, 2026
9 checks passed
@rajsite rajsite deleted the unit-format branch January 15, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants