Skip to content

Conversation

@rajsite
Copy link
Member

@rajsite rajsite commented Jan 1, 2026

Pull Request

🀨 Rationale

Switches to package exports in the react packages so dist/esm can be removed from the package names.

πŸ‘©β€πŸ’» Implementation

  • Updated package.json exports config and switched to package type module
  • Unrelated refactor: since we are on a modern node version which can import cjs from esm was able to remove the build step around the icon generation script, this can be done in the other packages but didn't do in this PR
  • Also included the styles scripts in the built packages πŸ˜…

πŸ§ͺ Testing

  • The normal build exercises moduleResolution: bundler in an example app and added a test tsconfig.legacy.json to exercise moduleResolution: node.
  • Checked the storybook tsconfig.tsbuildinfo and preview-stats.json for regressions on imports resolving to dist instead of src for turbopack

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite changed the title Switch to Switch to package exports for React packages Jan 1, 2026
@rajsite rajsite marked this pull request as ready for review January 2, 2026 06:02
@rajsite
Copy link
Member Author

rajsite commented Jan 2, 2026

@jattasNI bypassing for nights and weekends update to react package exports, can address feedback in follow-up

@rajsite rajsite merged commit 66f9a70 into main Jan 2, 2026
11 of 13 checks passed
@rajsite rajsite deleted the react-esm branch January 2, 2026 06:04
@rajsite rajsite mentioned this pull request Jan 2, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants