Skip to content

Conversation

@PieterGit
Copy link
Contributor

@PieterGit PieterGit commented Nov 3, 2017

First Node 8 LTS release. Recommended version for Nightscout will be the latest Node 8 LTS release.
We also run Travis with Node 9.0.0 to ensure Nightscout remains compatible with the future Node release.
(update: we won't run NodeJS 9.x on Travis for now)

…n both Node 8.9.0 and Node 9.0.0 (to make sure we don't introduce future problems with Node 9.0.0).

Node 8.9.0 LTS will be the recommended version.
@PieterGit PieterGit changed the base branch from master to dev November 3, 2017 09:45
@PieterGit
Copy link
Contributor Author

PieterGit commented Nov 3, 2017

Note on windows when I do npm update I get a warning:

npm WARN deprecated [email protected]: Use uuid module instead
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

+ [email protected]
+ [email protected]
+ [email protected]
+ [email protected]
+ [email protected]
+ [email protected]
added 115 packages and updated 6 packages in 22.681s

Because of this warning my npm-shrinkwrap.json will add ascli and remove all the fsevents dependencies. Is that a problem or should a Mac user do a npm update to make sure npm-shrinkwrap.json is complete?

@PieterGit
Copy link
Contributor Author

Failing Travis. @sulkaharo can you explain these errors?

Node 8.9.0 errors

not ok 161 Notifications API ack notifications
  AssertionError: expected -1 to be above -1
      at Assertion.fail (node_modules/should/cjs/should.js:231:17)
      at Assertion.value (node_modules/should/cjs/should.js:305:19)
      at containsLine (tests/hashauth.test.js:163:41)
      at Window.mockConfirm [as alert] (tests/hashauth.test.js:165:7)
      at Object._.addBasals (tmp/js/bundle.js:9:4468177)
      at Object.d.scroll (tmp/js/bundle.js:9:4535342)
      at L (tmp/js/bundle.js:9:3886936)
      at Timeout.C [as _onTimeout] (tmp/js/bundle.js:9:3894953)

not ok 183 Pebble Endpoint /pebble default(1) count
  AssertionError: expected 113984 to not exist
      at Test.<anonymous> (tests/pebble.test.js:116:20)
      at Test.assert (node_modules/supertest/lib/test.js:179:6)
      at Server.assert (node_modules/supertest/lib/test.js:131:12)
      at emitCloseNT (net.js:1655:8)
      at _combinedTickCallback (internal/process/next_tick.js:135:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

Node 9.0.0 error

not ok 30 authed REST api "before each" hook
  ReferenceError: $ is not defined
      at findOrCreatePill (lib/plugins/pluginbase.js:9:1731)
      at Object.updatePillText (lib/plugins/pluginbase.js:9:2725)
      at Object.updateVisualisation (lib/plugins/rawbg.js:9:2562)
      at eachPlugin (lib/plugins/index.js:9:6571)
      at arrayEach (node_modules/lodash/lodash.js:537:11)
      at Function.forEach (node_modules/lodash/lodash.js:9359:14)
      at Function.eachShownPlugins (lib/plugins/index.js:9:4678)
      at Function.updateVisualisations (lib/plugins/index.js:9:6326)
      at updatePlugins (lib/client/index.js:9:25861)
      at updateHeader (lib/client/index.js:9:29648)
      at brushed (lib/client/index.js:9:29892)
      at Timeout.updateClock [as _onTimeout] (lib/client/index.js:9:42375)

@sulkaharo
Copy link
Member

I would actually consider not running the Node 9 tests as we have no reason to adopt 9 and any fails there are node likely to be Node issues than our code, so we’d get to a constant upgrade cycle with bumping Travis to newer Node versions.

@PieterGit PieterGit changed the title Upgrade to node 8.9.0 LTS and let travis run on node 9.0.0 Upgrade to node 8.9.0 LTS Nov 3, 2017
@PieterGit
Copy link
Contributor Author

Dropped travis build for nodejs 9.0.0. Still need to investigate why the unit tests fail.

@PieterGit
Copy link
Contributor Author

PieterGit commented Nov 5, 2017

Running for two days, I found no regressions. When I removed the 9.0.0 build from Travis the 8.9.0 Travis build went ok. So we are running in a Travis issue here, and failing tests can be ignored (for now).

@sulkaharo : can you merge to dev?

@sulkaharo sulkaharo merged commit 27c0fc3 into nightscout:dev Nov 7, 2017
@PieterGit PieterGit deleted the 201711_node890_node900 branch November 7, 2017 23:02
@PieterGit
Copy link
Contributor Author

Thanks for merging

@PieterGit PieterGit restored the 201711_node890_node900 branch February 18, 2018 12:51
@PieterGit PieterGit deleted the 201711_node890_node900 branch December 24, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants