-
Notifications
You must be signed in to change notification settings - Fork 72.8k
Upgrade to node 8.9.0 LTS #3013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n both Node 8.9.0 and Node 9.0.0 (to make sure we don't introduce future problems with Node 9.0.0). Node 8.9.0 LTS will be the recommended version.
|
Note on windows when I do Because of this warning my |
|
Failing Travis. @sulkaharo can you explain these errors? Node 8.9.0 errors Node 9.0.0 error |
|
I would actually consider not running the Node 9 tests as we have no reason to adopt 9 and any fails there are node likely to be Node issues than our code, so we’d get to a constant upgrade cycle with bumping Travis to newer Node versions. |
…rs were gonna test against that version.
|
Dropped travis build for nodejs 9.0.0. Still need to investigate why the unit tests fail. |
|
Running for two days, I found no regressions. When I removed the 9.0.0 build from Travis the 8.9.0 Travis build went ok. So we are running in a Travis issue here, and failing tests can be ignored (for now). @sulkaharo : can you merge to dev? |
|
Thanks for merging |
First Node 8 LTS release. Recommended version for Nightscout will be the latest Node 8 LTS release.
We also run Travis with Node 9.0.0 to ensure Nightscout remains compatible with the future Node release.
(update: we won't run NodeJS 9.x on Travis for now)