Skip to content

Conversation

@elnjensen
Copy link

No description provided.

Update various package definitions to match changes that have been made through various edits since initial azurepush changes.
@PieterGit
Copy link
Contributor

@elnjensen : what code is using these dependencies? Is this required for Azure deploy?
I also pushed a PR for the latest Node version (8.9.1). See #3037

Probably best to integrate these PR's into one.
Can you confirm that NodeJS 8.9.1 is available on Azure?

@elnjensen
Copy link
Author

@PieterGit This branch is something totally different than a node version update. This wip/azurepush branch contains code that will let a new iOS version of the Nightscout mobile app do push notifications without using Pushover. I haven't been closely involved - this is work by @hackingtype1 and Andrew Ditmer - but much of the work was done a while ago, so I was just trying to get the package.json file in this branch closer to being parallel with the dependencies already present in dev so it would integrate cleanly. The only dependency changes added here are azure-sb and node-trello. And the "azure" in that package name relates to the message service used - runs fine on both Heroku and Azure. So I think you should proceed with your PR - this is unrelated. (Also note that this isn't yet a PR against dev or master - just trying to get this branch itself ready.)

@PieterGit
Copy link
Contributor

@elnjensen or @hackingtype1 . What's the state/progress of this PR? Do you think it's possible that this PR can be ready in at most two weeks. If not, I'll like to propose to set this feature for 0.11.0 (and not for 0.10.3)

@PieterGit
Copy link
Contributor

@elnjensen or @hackingtype1 . Can you give an update if this PR? Is still needed or can I close it. If it's needed can you explain for what features / code within Nightscout. I'm still a bit lost in this PR for package.json changes, without updates to Nightscout code to use these new packages.

@PieterGit PieterGit added this to the 0.11.0 milestone Jul 10, 2018
@PieterGit
Copy link
Contributor

@elnjensen or @hackingtype1. Postponing this PR to 0.11 release. Can you please give an update? If no response I think we should close or apply this PR and then close the branch.

@PieterGit
Copy link
Contributor

@elnjensen or @hackingtype1 can you give an update on this issue and this branch? Please also fix the failing tests. I would like to clean stale branches in the Nightscout 0.11 release cycle.

@elnjensen
Copy link
Author

@PieterGit I did this PR a while back to try to help those who opened this branch in the first place, but they seem not to be working on this any more. So I'm just going to close the PR. As for the branch itself, I didn't create it, so I don't know what should be done with it.

@elnjensen elnjensen closed this Aug 6, 2018
@elnjensen elnjensen deleted the wip/azurepush branch August 24, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants