Format webpack config & exclude node_modules directory #3819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nielsvanvelzen thanks for finding this bug. Please target PR's at the |
PieterGit
added a commit
to PieterGit/cgm-remote-monitor
that referenced
this pull request
Sep 29, 2018
…20.2 and reimplement nightscout#3819 (webpack)
Contributor
Contributor
|
@nielsvanvelzen thanks for finding and PR'ing this bug. Sorry it took so long to take action. |
PieterGit
added a commit
to PieterGit/cgm-remote-monitor
that referenced
this pull request
Oct 13, 2018
tanja3981
pushed a commit
to tanja3981/cgm-remote-monitor
that referenced
this pull request
Nov 1, 2018
…20.2 and reimplement nightscout#3819 (webpack)
tanja3981
pushed a commit
to tanja3981/cgm-remote-monitor
that referenced
this pull request
Nov 1, 2018
tanja3981
pushed a commit
to tanja3981/cgm-remote-monitor
that referenced
this pull request
May 21, 2019
…20.2 and reimplement nightscout#3819 (webpack)
tanja3981
pushed a commit
to tanja3981/cgm-remote-monitor
that referenced
this pull request
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started using Nightscout a few weeks ago but when I tried to update to the latest version a few days ago it didn't work because my server (that was compiling it) only had 512MB memory.
After some digging I found out that this was caused by the webpack config not excluding
node_modulesfrom the ruels for image + css loading.When testing on my Windows machine memory usage went from a peak of 1.5GB to 200MB. Compile times got speed up too.
After testing I can confirm that everything is still working (tested the admin & clocks in particular)