Skip to content

Conversation

@mrksmaurer
Copy link

Blutzucker und blutzucker hinzugefügt

Blutzucker und blutzucker hinzugefügt
@PieterGit
Copy link
Contributor

@mrksmaurer Please target changes at the dev branch instead of the master branch. Are you sure this is the way multilingual changes to Nightscout should be implemented?

@veryfancy or other Alexa users, can you please take ownership of the Alexa issues/PR's?

Targeting this change to 0.12 for now. If the discussion is done and this is the way it should be implemented it can be merged to 0.11.

@PieterGit PieterGit added this to the 0.12.0 milestone Sep 29, 2018
@PieterGit PieterGit changed the title Update index.js 2018-09-18 Alexa multilingual changes: Blutzucker und blutzucker Sep 29, 2018
@PieterGit
Copy link
Contributor

@mrksmaurer or @veryfancy . Can you give an update. If no clear update or concensus I will close this PR.

@tanja3981
Copy link
Contributor

I think this use case (translatable metrics) are better solved otherwise than adding those metric hardcoded to the code. With other language we would have to add "blood glucose" accordingly.
I think a better way would be do use the alexa skill synonyms for it, but I'm biased due to my PR (#4040 ) for that. ;-)

@PieterGit PieterGit removed this from the 0.12.0 milestone Oct 20, 2019
@PieterGit
Copy link
Contributor

@mrksmaurer @veryfancy @tanja3981 Is this PR still relevant?

@inventor96 Is there a generic way this can be implemented for several languages?

If relevant, please reopen, rebase on the dev branch, and resolve the merge conflicts.

Closing PR for now.

@PieterGit PieterGit closed this Oct 20, 2019
@inventor96
Copy link
Contributor

inventor96 commented Oct 20, 2019

@mrksmaurer @veryfancy @tanja3981 @PieterGit Per the changes made in #4980, the best way to add support for another language is in the virtual assistant configuration in the respective console (Alexa or Google Home/DialogFlow). As @tanja3981 said, synonyms are helpful, but one really should setup the additional language in the respective console first, and then use the synonyms. I've added a section in both the Alexa and Google Home documentation called "Adding support for additional languages" that outlines the process for each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants