Skip to content

Workaround for re-loading bug in profile editor: don't show profile form during save #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PieterGit merged 5 commits into from
Feb 2, 2019
Merged

Workaround for re-loading bug in profile editor: don't show profile form during save #4074

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93be1a6
Merge pull request #3 from nightscout/dev
DigitalDan1 Nov 16, 2018
4271a81
Fix re-loading bug in profile editor and ensure changes made by the u…
DigitalDan1 Nov 16, 2018
a0f0ef4
Fix re-loading bug in profile editor and ensure changes made by the u…
DigitalDan1 Nov 16, 2018
7022079
Merge remote-tracking branch 'upstream/dev' into dev
DigitalDan1 Jan 30, 2019
cefa000
Merge branch 'dev' of https://github.com/DigitalDan1/cgm-remote-monit…
DigitalDan1 Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions static/profile/js/profileeditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@

client.init(function loaded () {

if (c_profile !== null) {
return; // already loaded so don't load again
}

var translate = client.translate;

var defaultprofile = {
Expand Down Expand Up @@ -678,20 +682,28 @@
delete adjustedRecord.convertedOnTheFly;

console.info('saving profile');
peStatus.hide().text('saving profile').fadeIn('slow');

// Hide the form until the ajax PUT is done.
// This is a crude way of preventing the user from changing the inputs whilst waiting.
// If the user was able to make changes, they'd be lost when the done callback redraws anyway.
$('#pe_form').hide();

$.ajax({
method: 'PUT'
, url: '/api/v1/profile/'
, data: adjustedRecord
, headers: client.headers()
}).done(function postSuccess (data, status) {
console.info('profile saved', data);
$('#pe_form').show(); // allow edits again
peStatus.hide().text(status).fadeIn('slow');
record._id = data._id;
initRecord();
dirty = false;
}).fail(function(xhr, status, errorThrown) {
console.error('Profile not saved', status, errorThrown);
$('#pe_form').show(); // allow edits again
peStatus.hide().text(status).fadeIn('slow');
});
return false;
Expand Down