Remove unused alarm-pumpbatterylow-browser client setting

[jpcunningh]

I've tested and still receive pump battery low alarms with this code removed.

[sulkaharo]

Did you check the git history of how these landed into the codebase?

[PieterGit]

@jpcunningh @sulkaharo
I did a git history check. I added it in the final part of the 0.10.3 release. We had some issues with the speech plugin (solved now). It was added with commit 1769f2d#diff-d878eabd64038e07845b240469aa46ca and it was part of #3709

From that issue:
I had serious problems with Warning, Pump Battery Low alarm.
It was is audible, but could not be surpressed or disabled in the UI. I started adding the UI for disabling it, but it does not seem to work yet. There is some strange issue with these pump alarms. Temporary workaround is PUMP_ENABLE_ALERTS=false, but of course PUMP_ENABLE_ALERTS=true should not lead to alarms that cannot be stopped and cannot be disabled in the UI.

I just had an empty battery, and currently it seems the battery alarm does not respect the setting in the UI (the alarm for low battery was audible with the setting "Pump Battery Low Alarm" enabled or disabled)

[PieterGit]

@jpcunningh @sulkaharo do you have any idea why the alarm-pumpbatterylow-browser does not work. I rather fix it that it works, than remove it. Agree with postponing this to 0.12?

[jpcunningh]

@PieterGit, I have no problem with postponing.

We haven't experienced any of the symptoms you described. Do you see the symptoms on different browsers?

[bebergamota]

Cancelar. unsubscribe please Em qui, 6 de fev de 2020 13:06, Jeremy Cunningham <[email protected]> escreveu:

…

Closed #4217 <#4217>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4217?email_source=notifications&email_token=ALWENIMARTHPS5TZKR3XBC3RBQYPLA5CNFSM4GRFWZCKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWOWWIWI#event-3014485081>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALWENIP5VQIBKIHALDPLHNTRBQYPLANCNFSM4GRFWZCA> .