Refactor in-memory caching #6056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sulkaharo
commented
Sep 20, 2020
sulkaharo
commented
- Now supports cache updates and flushing from persistence layer, so treatment updates and removes are immediately reflected in runtime state
- Cleaner separation of concerns between data loader and caching
* Refactoring the cache: moved to another file and support flushing from bus events
…use the new model and reduce queries back down
This was referenced Sep 20, 2020
Member
|
This looks like it extends the previous effort all the way to the storage layer for each collection. Do we have any idea which apps or how many people would be affected by an app with degraded performance due to rejected entries? Arguably "none" since that data is essentially orphaned. |
* Remove the validation for created_at in REST API ;(
Member
Author
|
Merged given thumbs up from multiple testers, including AAPS users |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.