Skip to content

Add unit test for socket.io connect #6845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sulkaharo merged 2 commits into from
Feb 4, 2021
Merged

Add unit test for socket.io connect #6845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fcbc00
Add unit test for socket.io connect
sulkaharo Feb 4, 2021
69b31b4
Fix white space
sulkaharo Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions lib/server/websocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,10 @@ function init (env, ctx, server) {

function verifyAuthorization (message, ip, callback) {

if (!message) return;
if (!message.token && !message.secret) return;
if (!message || !message.token && !message.secret) {
callback('Bad request', null);
return;
}

ctx.authorization.resolve({ api_secret: message.secret, token: message.token, ip: ip }, function resolved (err, result) {

Expand Down Expand Up @@ -256,9 +258,7 @@ function init (env, ctx, server) {
}

var objId = new ObjectID(data._id);
ctx.store.collection(collection).update(
{ '_id': objId },
{ $unset: data.data }
ctx.store.collection(collection).update({ '_id': objId }, { $unset: data.data }
, function(err, results) {

if (!err) {
Expand All @@ -274,7 +274,7 @@ function init (env, ctx, server) {
}
});
}
});
});

if (callback) {
callback({ result: 'success' });
Expand Down Expand Up @@ -329,7 +329,7 @@ function init (env, ctx, server) {
callback([]);
return;
}

if (array.length > 0) {
console.log(LOG_DEDUP + 'Exact match');
if (callback) {
Expand Down Expand Up @@ -379,7 +379,7 @@ function init (env, ctx, server) {
callback([]);
return;
}

if (array.length > 0) {
console.log(LOG_DEDUP + 'Found similiar', array[0]);
array[0].created_at = data.data.created_at;
Expand Down Expand Up @@ -433,12 +433,12 @@ function init (env, ctx, server) {

if (array.length > 0) {
console.log(LOG_DEDUP + 'Devicestatus exact match');
if (callback) {
callback([array[0]]);
}
return;
if (callback) {
callback([array[0]]);
}
return;
}

});

ctx.store.collection(collection).insert(data.data, function insertResult (err, doc) {
Expand All @@ -464,7 +464,7 @@ function init (env, ctx, server) {
console.log(data.collection + ' insertion error: ', err.message);
return;
}

ctx.bus.emit('data-update', {
type: data.collection
, op: 'update'
Expand Down Expand Up @@ -526,6 +526,15 @@ function init (env, ctx, server) {
socket.on('authorize', function authorize (message, callback) {
const remoteIP = socket.request.connection.remoteAddress;
verifyAuthorization(message, remoteIP, function verified (err, authorization) {

if (err) {
console.log('Websocket authorization failed:', err);
socket.disconnect();
return;
}

socket.emit('connected');

socketAuthorization = authorization;
clientType = message.client;
history = message.history || 48; //default history is 48 hours
Expand Down
144 changes: 110 additions & 34 deletions tests/security.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,25 @@
'use strict';

var request = require('supertest');
var should = require('should');
var language = require('../lib/language')();
const request = require('supertest');
const should = require('should');
const language = require('../lib/language')();
const io = require('socket.io-client')

describe('API_SECRET', function ( ) {
describe('API_SECRET', function() {
var api;
var scope = this;
this.timeout(5000);
var websocket;
var app;
var server;
var listener;

this.timeout(7000);

afterEach(function() {
if (listener) {
listener.close();
}
});

function setup_app (env, fn) {
api = require('../lib/api/');
Expand All @@ -19,74 +31,138 @@ describe('API_SECRET', function ( ) {
});
}

it('should fail when unauthorized', function (done) {
function setup_big_app (env, fn) {
api = require('../lib/api/');
require('../lib/server/bootevent')(env, language).boot(function booted (ctx) {
ctx.app = api(env, ctx);
scope.app = ctx.app;
scope.entries = ctx.entries;

app = require('../lib/server/app')(env, ctx);
server = require('http').createServer(app);
listener = server.listen(1337, 'localhost');
websocket = require('../lib/server/websocket')(env, ctx, server);

fn(ctx);
});
}

it('should fail when unauthorized', function(done) {
var known = 'b723e97aa97846eb92d5264f084b2823f57c4aa1';

delete process.env.API_SECRET;
process.env.API_SECRET = 'this is my long pass phrase';
var env = require('../lib/server/env')( );
var env = require('../lib/server/env')();

env.enclave.isApiKey(known).should.equal(true);

setup_app(env, function (ctx) {
setup_app(env, function(ctx) {
ctx.app.enabled('api').should.equal(true);
ping_status(ctx.app, again);
function again ( ) {

function again () {
ctx.app.api_secret = '';
ping_authorized_endpoint(ctx.app, 401, done);
}
});

});


it('should work fine set', function (done) {
it('should work fine set', function(done) {
var known = 'b723e97aa97846eb92d5264f084b2823f57c4aa1';
delete process.env.API_SECRET;
process.env.API_SECRET = 'this is my long pass phrase';
var env = require('../lib/server/env')( );
var env = require('../lib/server/env')();
env.enclave.isApiKey(known).should.equal(true);
setup_app(env, function (ctx) {
setup_app(env, function(ctx) {
ctx.app.enabled('api').should.equal(true);
ping_status(ctx.app, again);
function again ( ) {

function again () {
ctx.app.api_secret = known;
ping_authorized_endpoint(ctx.app, 200, done);
}
});

});

it('should not work short', function ( ) {
it('should not work short', function() {
delete process.env.API_SECRET;
process.env.API_SECRET = 'tooshort';
var env = require('../lib/server/env')( );
var env = require('../lib/server/env')();
should.not.exist(env.api_secret);
env.err[0].desc.should.startWith('API_SECRET should be at least');
});

function ping_status (app, fn) {
request(app)
.get('/status.json')
.expect(200)
.end(function (err, res) {
res.body.status.should.equal('ok');
fn( );
});
request(app)
.get('/status.json')
.expect(200)
.end(function(err, res) {
res.body.status.should.equal('ok');
fn();
});
}

function ping_authorized_endpoint (app, fails, fn) {
request(app)
.get('/experiments/test')
.set('api-secret', app.api_secret || '')
.expect(fails)
.end(function (err, res) {
if (fails < 400) {
res.body.status.should.equal('ok');
}
fn( );
});
request(app)
.get('/experiments/test')
.set('api-secret', app.api_secret || '')
.expect(fails)
.end(function(err, res) {
if (fails < 400) {
res.body.status.should.equal('ok');
}
fn();
});
}

});
it('socket IO should connect', function(done) {

var known = 'b723e97aa97846eb92d5264f084b2823f57c4aa1';
process.env.API_SECRET = 'this is my long pass phrase';
var env = require('../lib/server/env')();

setup_big_app(env, function(ctx) {

const socket2 = io.connect('ws://localhost:1337/');

socket2.on('connect', function() {
console.log('Socket 2 authorizing');
socket2.emit("authorize", {
secret: known
});
});

socket2.on('disconnect', function() {
//socket.emit("authorize");
console.log('Client 2 disconnected');
done();
});

socket2.on('connected', function(msg) {
console.log('Connected');

// Disconnect both client connections
socket2.disconnect();

const socket = io.connect('ws://localhost:1337/');

socket.on('connect', function() {
console.log('Socket 1 authorizing');
socket.emit("authorize");
});

socket.on('disconnect', function() {
//socket.emit("authorize");
console.log('Client 1 disconnected');
done();
});

});

});

});

});