Skip to content

Wip/bewest/upgrade node #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bewest merged 12 commits into from
Jun 30, 2022
Merged

Wip/bewest/upgrade node #7343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6dc2b2b
mark compatible with node 14 and node 16
bewest Feb 16, 2022
fabd798
add node 16 to supported list
bewest Feb 16, 2022
ded6fa9
Test against nodejs 16.x
viq Mar 2, 2022
06012e5
Merge branch 'dev' into wip/bewest/upgrade-node
bewest Apr 30, 2022
a1a2e74
npm install share2nightscout-bridge@^0.2.9
bewest Jun 30, 2022
5cf72ce
npm install minimed-connect-to-nightscout@^1.5.3
bewest Jun 30, 2022
3e2520b
Merge branch 'viq-patch-2' into wip/bewest/upgrade-node
bewest Jun 30, 2022
e715cd2
give automated tests more time to finish
bewest Jun 30, 2022
cef684e
Merge branch 'dev' into wip/bewest/upgrade-node
bewest Jun 30, 2022
ead83e0
npm audit fix
bewest Jun 30, 2022
08e2225
Merge branch 'wip/bewest/upgrade-node' of github.com:nightscout/cgm-r…
bewest Jun 30, 2022
0d1aed7
Revert "npm audit fix" due to test failure
bewest Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x]
node-version: [12.x, 14.x, 16.x]
mongodb-version: [4.2, 4.4]

steps:
Expand Down
2 changes: 1 addition & 1 deletion lib/server/bootevent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function boot (env, language) {

const isLTS = process.release.lts ? true : false;

if (isLTS && (semver.satisfies(nodeVersion, '^14.0.0') || semver.satisfies(nodeVersion, '^12.0.0') || semver.satisfies(nodeVersion, '^10.0.0'))) {
if (isLTS && (semver.satisfies(nodeVersion, '^16.0.0') || semver.satisfies(nodeVersion, '^14.0.0') || semver.satisfies(nodeVersion, '^12.0.0') || semver.satisfies(nodeVersion, '^10.0.0'))) {
//Latest Node 10 LTS and Node 12 LTS are recommended and supported.
//Require at least Node 8 LTS and Node 10 LTS without known security issues
console.debug('Node LTS version ' + nodeVersion + ' is supported');
Expand Down
Loading