Skip to content

Delete v3 api identifiers when cloning a record in profile editor #7839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sulkaharo merged 5 commits into from
Jan 23, 2023
Merged

Delete v3 api identifiers when cloning a record in profile editor #7839

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74bcc3d
Delete v3 api identifiers when cloning a record
sulkaharo Jan 18, 2023
ea65011
Refactored to use lodash omit
sulkaharo Jan 18, 2023
3f72f28
Move cleaning logic to correct function, add _id to list of cleaned p…
sulkaharo Jan 18, 2023
6b841fa
Add back a line that was accidentally deleted
sulkaharo Jan 19, 2023
ffb14c9
profileeditor: add created_at, srvModified too on save to simulate AP…
MilosKozak Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/profile/profileeditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,9 @@ var init = function init () {
newname += '1';
}
record.store[newname] = _.cloneDeep(record.store[currentprofile]);
var r = record.store[newname];
if (r.srvModified) delete r.srvModified;
Copy link
Member

@bewest bewest Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider record.store[newname] = _.omit(r, 'srvModified') ? Optional.

if (r.srvCreated) delete r.srvCreated;
currentprofile = newname;
dirty = true;

Expand Down