Wip/bewest/api secret free reads #8085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows the operator to control whether or not the API Secret authentication dialog will display by default or not. Historically Nightscout allows a configuration to be readable and to send alarm information to all displays. A change in in dev in February to support authentication and api v3 introduced a new configuration where websocket communication is authenticated, and the API Secret modal will display if it authenticates in error. The side-effect is that all new instances, even readable instances with glucose data, can't be seen or monitored without putting in the API Secreet or explicitly dismissing it. This patch returns to the default behavior while allowing to select the new one using authenticationPromptOnLoad in the settings communicated from server to client. If people strongly prefer, we can reverse to the new behavior over time. To select the old behavior with no API Secret needed for readabable data, do nothing. To select the new behavior where the API Secret prompts occur on load, set `AUTHENTICATION_PROMPT_ON_LOAD=1`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow readable Nightscouts to read without prompting for the an api secret or token.