@fredmk's axios refactor rebased on dev #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bewest
changed the title
Member
|
Great! Do we need a branch of Nightscout that points to this to enable testing? |
Member
Author
|
Yes, I've been trying to test it a little bit more since there are substantial changes, but short on time. If we think a bounty/contract could solve this for reasonable price, T1Pal might be willing to fund development on this. |
Member
Author
|
Tying it all together: |
bewest
commented
Dec 4, 2020
|
|
||
| var logger = require('./logger'); | ||
|
|
||
| process.env["NODE_TLS_REJECT_UNAUTHORIZED"] = 0; |
Member
Author
There was a problem hiding this comment.
Nervous about shipping this to production. We would like to validate that we are talking to Medtronic without someone tampering.
Contributor
There was a problem hiding this comment.
the current code not using this
This was referenced Dec 5, 2020
testing against international servers takes longer.
Member
Author
|
@FredMK, your changes are merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rebased the axios branch on top of dev with these results.
https://github.com/FredMK/minimed-connect-to-nightscout/tree/axios