Skip to content

Allocator: Handle basic dead threads with unshared memory #23878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SirOlaf wants to merge 19 commits into
base: devel
Choose a base branch
from
+67 −28
Open

Allocator: Handle basic dead threads with unshared memory #23878

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
61c9726
Thread cleanup attempt #0
Jul 22, 2024
343ec19
Give each MemRegion a unique key
Jul 22, 2024
fc3a658
Notify chunks
Jul 22, 2024
35dce48
Merge branch 'devel' into allocator-thread-cleanup
SirOlaf Jul 22, 2024
7dff519
Attempt #1
Jul 22, 2024
c66bc48
Dealloc page
Jul 22, 2024
2d1b2c6
Simplify
Jul 22, 2024
29b4a86
Check malloc
Jul 25, 2024
4afc7c4
Only enable for destructors
Jul 25, 2024
0e16c42
Also check malloc
Jul 25, 2024
0501c97
Remove comment
SirOlaf Oct 17, 2024
ed2a7df
Merge branch 'devel' into allocator-thread-cleanup
SirOlaf Oct 17, 2024
28ca5de
Don't use small chunks like a list anymore
Oct 17, 2024
4c8c979
Keep a count of big chunks and small cells for abandonAllocator
Oct 17, 2024
da5b55a
Remove unused experiment
Oct 17, 2024
2bfdc79
Adjust smallCellsInUse in compensateCounters
Oct 17, 2024
ea71530
Handle edge case
Nov 5, 2024
87c4ef0
Merge branch 'devel' into allocator-thread-cleanup
SirOlaf Nov 5, 2024
822ef0e
Check gcDestructors
Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove comment
  • Loading branch information
@SirOlaf
SirOlaf authored Oct 17, 2024
commit 0501c973e3342d7d3f78f56b3cdb071780f2e619
1 change: 0 additions & 1 deletion lib/system/alloc.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,7 +1202,6 @@ proc realloc0(allocator: var MemRegion, p: pointer, oldsize, newsize: Natural):
zeroMem(cast[pointer](cast[uint](result) + uint(oldsize)), newsize - oldsize)

proc abandonAllocator(a: var MemRegion) =
# There may be a race condition here...
if a.chunksInUse == 0:
# Deallocating is only safe if all chunks are unused
deallocOsPages(a)
Expand Down