open scope for each when nimvm branch
#24306
Draft
+43
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes nim-lang#23687, fixes nim-lang#23688, refs nim-lang#13450
Collaborator
Author
|
Every case caught in package CI seems correctly failing. Things like this were already not possible but this is maybe still slightly annoying: when nimvm:
let a = 123
else:
let a = 456 |
Araq
pushed a commit
that referenced
this pull request
Nov 5, 2024
ref #24225 related #24306 > Code in branches must not affect semantics of the code that follows the `when nimvm` statement. E.g. it must not define symbols that are used in the following code. The test shouldn't have passed when #24306 would be implemented somehow. Some third packages have already misused `when nimvm` by defining symbols in the other branch of `when nimvm`. e.g. in status-im/nim-unittest2#34 ```nim when nimvm: discard else: let suiteName {.inject.} = nameParam use(suiteName) ```
narimiran
pushed a commit
that referenced
this pull request
Jan 14, 2025
ref #24225 related #24306 > Code in branches must not affect semantics of the code that follows the `when nimvm` statement. E.g. it must not define symbols that are used in the following code. The test shouldn't have passed when #24306 would be implemented somehow. Some third packages have already misused `when nimvm` by defining symbols in the other branch of `when nimvm`. e.g. in status-im/nim-unittest2#34 ```nim when nimvm: discard else: let suiteName {.inject.} = nameParam use(suiteName) ``` (cherry picked from commit c71de10)
metagn
changed the title
when nimvm branchwhen nimvm branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23687, fixes #23688, refs #13450
Package PRs:
untypedparameters) - removewhen nimvmcondition for keccak declarations cheatfate/nimcrypto#83when, branch already always compiles) - removewhen nimvmcondition to import mratsim/constantine#529when) - removewhen nimvmcondition forgState/gStateCTdeclarations nimterop/nimterop#302