Skip to content

always reinstantiate nominal values of generic instantiations #24425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Araq merged 11 commits into from
Nov 16, 2024
Merged

always reinstantiate nominal values of generic instantiations #24425

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39a88ff
test always instantiating nominal generic insts
metagn Nov 9, 2024
46af4dd
fix enums, add preexisting bug tests
metagn Nov 9, 2024
f2cd8bb
try generic subtype fix first
metagn Nov 10, 2024
21f6b4d
test slight refactor
metagn Nov 10, 2024
14f03fc
try destructor fix
metagn Nov 10, 2024
ebc39d7
use separate type flag
metagn Nov 10, 2024
cd49438
test ref objects
metagn Nov 10, 2024
813d650
test preexisting jsonutils bug
metagn Nov 10, 2024
95d7014
fix proc instantiations for dereferenced ref object types
metagn Nov 10, 2024
a37c2a6
Merge branch 'devel' of https://github.com/nim-lang/Nim into nominal-…
metagn Nov 12, 2024
08e9625
while CI is running, fix comments
metagn Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'devel' of https://github.com/nim-lang/Nim into nominal-… 
…generic-inst
  • Loading branch information
@metagn
metagn committed Nov 12, 2024
commit a37c2a6bb313aba88ce3bbe1f0e073c88a03568b
4 changes: 2 additions & 2 deletions tests/objects/tgenericsubtype.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
block:
block: # has generic field
type
Foo[T] = object of RootObj
x: T
Expand All @@ -8,7 +8,7 @@ block:

foo(Bar)

block:
block: # no generic field
type
Foo[T] = object of RootObj
Bar = object of Foo[int]
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.